-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated use of 'Repository' when pushing to hub with HfApi
#462
Conversation
…ferent apparently, change?)
Hello, |
I just want to double-check whether what I'm doing now is also okay: I will cherry-pick the commits I made to the branch and add them to master. Should I then create a new PR that originates from master? Sorry for the hassle, I haven't contributed much to open-source so I'm not incredibly familiar with all the conventions! 🥲 (I was following the huggingface course when I found this issue, and though |
Almost. Start from master, create a new branch, cherry-pick the commits and then push (you could even force push to this branch). EDIT: hf was for huggingface but this branch has been merged a while ago, I will delete it now. |
Closing in favour of #465 |
* Commits from #462 * update ci * `hf_hub_download` -> `snapshot_download` * fix local dir; handle lfs for mp4 * rm line --------- Co-authored-by: Quentin Gallouédec <quentin.gallouedec@huggingface.co> Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Remove deprecated use of 'Repository' when pushing to huggingface hub
Description
As mentioned above, use of the
Repository
class is deprecated: https://hu…ggingface.co/docs/huggingface_hub/concepts/git_vs_http.Motivation and Context
Closes #463 🥳
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line