Remove empty Log_Msg_* ctors

DOCGroup · Jul 14, 2024 · b1f2dd6 · b1f2dd6
1 parent 2431f5e
commit b1f2dd6
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 36 deletions.
diff --git a/ACE/ace/Log_Msg_Android_Logcat.h b/ACE/ace/Log_Msg_Android_Logcat.h
@@ -35,7 +35,6 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
 class ACE_Export ACE_Log_Msg_Android_Logcat : public ACE_Log_Msg_Backend
 {
 public:
-  ACE_Log_Msg_Android_Logcat () = default;
   ~ACE_Log_Msg_Android_Logcat () override;
 
   /// Initialize the event logging facility. NOP in this class.

diff --git a/ACE/ace/Log_Msg_Backend.cpp b/ACE/ace/Log_Msg_Backend.cpp
@@ -1,9 +1 @@
 #include "ace/Log_Msg_Backend.h"
-
-ACE_BEGIN_VERSIONED_NAMESPACE_DECL
-
-ACE_Log_Msg_Backend::~ACE_Log_Msg_Backend ()
-{
-}
-
-ACE_END_VERSIONED_NAMESPACE_DECL
diff --git a/ACE/ace/Log_Msg_Backend.h b/ACE/ace/Log_Msg_Backend.h
@@ -40,7 +40,7 @@ class ACE_Export ACE_Log_Msg_Backend
 {
 public:
   /// No-op virtual destructor.
-  virtual ~ACE_Log_Msg_Backend ();
+  virtual ~ACE_Log_Msg_Backend () = default;
 
   /**
    * Open the back end object. Perform any actions needed to prepare

diff --git a/ACE/ace/Log_Msg_Callback.cpp b/ACE/ace/Log_Msg_Callback.cpp
@@ -1,9 +1 @@
 #include "ace/Log_Msg_Callback.h"
-
-ACE_BEGIN_VERSIONED_NAMESPACE_DECL
-
-ACE_Log_Msg_Callback::~ACE_Log_Msg_Callback ()
-{
-}
-
-ACE_END_VERSIONED_NAMESPACE_DECL
diff --git a/ACE/ace/Log_Msg_Callback.h b/ACE/ace/Log_Msg_Callback.h
@@ -52,11 +52,8 @@ class ACE_Log_Record;
 class ACE_Export ACE_Log_Msg_Callback
 {
 public:
-  /// Default constructor
-  ACE_Log_Msg_Callback () = default;
-
   /// No-op virtual destructor.
-  virtual ~ACE_Log_Msg_Callback ();
+  virtual ~ACE_Log_Msg_Callback () = default;
 
   /// Callback routine.  This is called when we want to log a message.
   /// Since this routine is pure virtual, it must be overwritten by the

diff --git a/ACE/ace/Log_Msg_IPC.h b/ACE/ace/Log_Msg_IPC.h
@@ -49,9 +49,6 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
 class ACE_Export ACE_Log_Msg_IPC : public ACE_Log_Msg_Backend
 {
 public:
-  /// Constructor
-  ACE_Log_Msg_IPC () = default;
-
   /// Destructor
   ~ACE_Log_Msg_IPC () override;
 

diff --git a/ACE/ace/Log_Msg_NT_Event_Log.h b/ACE/ace/Log_Msg_NT_Event_Log.h
@@ -33,9 +33,6 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
 class ACE_Export ACE_Log_Msg_NT_Event_Log : public ACE_Log_Msg_Backend
 {
 public:
-  /// Constructor
-  ACE_Log_Msg_NT_Event_Log () = default;
-
   /// Destructor
   ~ACE_Log_Msg_NT_Event_Log () override;
 

diff --git a/ACE/ace/Log_Msg_UNIX_Syslog.h b/ACE/ace/Log_Msg_UNIX_Syslog.h
@@ -34,11 +34,8 @@ ACE_BEGIN_VERSIONED_NAMESPACE_DECL
 class ACE_Export ACE_Log_Msg_UNIX_Syslog : public ACE_Log_Msg_Backend
 {
 public:
-  /// Constructor
-  ACE_Log_Msg_UNIX_Syslog () = default;
-
   /// Destructor
-  virtual ~ACE_Log_Msg_UNIX_Syslog ();
+  ~ACE_Log_Msg_UNIX_Syslog () override;
 
   /// Open a new event log.
   /**
@@ -48,16 +45,16 @@ class ACE_Export ACE_Log_Msg_UNIX_Syslog : public ACE_Log_Msg_Backend
    *                   it is 0 (no name), the application name as
    *                   returned from ACE_Log_Msg::program_name() is used.
    */
-  virtual int open (const ACE_TCHAR *logger_key);
+  int open (const ACE_TCHAR *logger_key) override;
 
   /// Reset the backend.
-  virtual int reset ();
+  int reset () override;
 
   /// Close the backend completely.
-  virtual int close ();
+  int close () override;
 
   /// This is called when we want to log a message.
-  virtual ssize_t log (ACE_Log_Record &log_record);
+  ssize_t log (ACE_Log_Record &log_record) override;
 
 private:
   /// Convert an ACE_Log_Priority value to the corresponding syslog priority.