Consolidate reactor timer management functions #2301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
ACE_Reactor
and its base class,ACE_Reactor_Timer_Interface
have identical implementations forschedule_timer
andreset_timer_interval
member template functions.Solution: Bring the base class's member functions into the scope of the
ACE_Reactor
class withusing
.The original attempt was to remove the duplicate member functions from
ACE_Reactor
while keeping the ones from the base class. However, this does not work since the base class's member template functions are not visible inACE_Reactor
with the presence of the overloads forschedule_timer
andreset_timer_interval
withACE_Time_Value
. This change brings the base class'sschedule_timer
andreset_timer_interval
member templates into the scope of theACE_Reactor
class so that we no longer need the identical implementations inACE_Reactor
.