-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just for comparision #14
base: master
Are you sure you want to change the base?
Conversation
…texvcjs_readinfile.js). Also added a test case for mathmode.js under test/mathmodetest.js.
"\\gnapprox", | ||
"\\gneq", | ||
"\\gneqq", | ||
"\\gnsim", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need this lists.
@notjagan I think coping from files from texvcjs is not a good idea. Why can't you add texvc as node dependency? |
@physikerwelt I was originally planning on having texvcjs as a dependency for texer. However, in order for me to create parsing for the macro definitions based on DRMFfcns.sty, I need to dynamically modify the files belonging to texvcjs. For example, I have to add code to parser.pegjs for each of the functions specified within the .sty file, which wouldn't be easily possible with texvcjs simply as a dependency. |
…or tracking progress)
@physikerwelt What would you recommend in terms of the relationship between texer and texvcjs? I would like add texvcjs as a dependency so I don't have to manually transfer all the changes that I make on texvcjs over to texer, but I have to add code to texvcjs dynamically in texer. As such, I am unsure on how to treat texvcjs as it used in texer. The only idea I have right now is give texvcjs the ability to accept modifications through a function and have it deal with the changes itself. |
In general that seems to be a good approach. But I do not understand the details. |
@notjagan Can you give @physikerwelt some details, as above? |
@physikerwelt As of right now, my branch of
In addition to generating pegJS, my code also generates JavaScript for adding rules to |
@notjagan the question is where in the pegjs file you want to edit the new rules. If you modify one line in the texvcjs code, i.e make the location of the grammar file configureable |
do not merge!