Frontend: Minor UI Fixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
IsaacMilarky
approved these changes
Sep 18, 2024
|
Looks good! The only thing I'd do is add a line space where you see the red X's here. This will prevent the UI elements from running together. I'm also inclined to add "your" so it's "your results data". TY! |
|
Requested minor updates: line spacing and inserting 1 word. |
…utton in index.html Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
|
Done! Will merge this PR in so we can have the build ready for tomorrow's beta session |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend: Minor UI Fixes
Problem
Made a couple of minor UI fixes based on Meg's feedback on #131
#131 (comment)
Solution
index.html, 2nd line wraps right under the first bullet pointsuccess.html, changed to a numbered list & "See examples" wraps under number 2.Result
index.html:
success.html:
Test Plan
npm testto run frontend tests