Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron from 28.0.0 to 33.0.2 in /frontend #188

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps electron from 28.0.0 to 33.0.2.

Release notes

Sourced from electron's releases.

electron v33.0.2

Release Notes for v33.0.2

Fixes

  • Fixed trace-startup not working on macOS. #44276 (Also in 32, 34)
  • Fixed an issue where closing a window after printing on Linux triggered a crash. #44285 (Also in 31, 32, 34)
  • Fixed an issue where the exit event could be emitted twice from the utilityProcess. #44266 (Also in 31, 32, 34)
  • Fixed calling setAlwaysOnTop on a hidden window which is then shown with showInactive on Linux under X11. #44324 (Also in 31, 32, 34)
  • Fixed race condition in which WebContents appears as white screen on VDI machines without hardware acceleration capabilities. #44352 (Also in 32, 34)

electron v33.0.1

Release Notes for v33.0.1

Other Changes

  • Updated Chromium to 130.0.6723.59. #44271

electron v33.0.0

Release Notes for 33.0.0

Stack Upgrades

Breaking Changes

  • Deprecated usage of textured BrowserWindow type option on macOS. #43133
  • Custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated protocol.registerFileProtocol and the baseURLForDataURL property on BrowserWindow.loadURL, WebContents.loadURL, and <webview>.loadURL. #43977

Features

Additions

  • Added a handler, app.setClientCertRequestPasswordHandler(handler), to help unlock cryptographic devices when a PIN is needed. #41205
  • Added error event in utility process to support diagnostic reports on V8 fatal errors. #43997
  • Added View.setBorderRadius(radius) for customizing the border radius of views—with compatibility for WebContentsView. #42320
  • Added Linux support for the Windows Control Overlay API. #41769 (Also in 30, 31, 32)
  • Added support for the macOS system picker in desktopCapturer and setDisplayMediaRequestHandler. #43680 (Also in 32)
  • Added DownloadItem.getCurrentBytesPerSecond(), DownloadItem.getPercentComplete(), DownloadItem.getEndTime(). #42805 (Also in 30, 31, 32)
  • Added a new property prefersReducedTransparency to nativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. #42862 (Also in 30, 31, 32)
  • Added support for responding to auth requests initiated from utility process via app#login event. #42631 (Also in 32)

Improvements

... (truncated)

Changelog

Sourced from electron's changelog.

Breaking Changes

Breaking changes will be documented here, and deprecation warnings added to JS code where possible, at least one major version before the change is made.

Types of Breaking Changes

This document uses the following convention to categorize breaking changes:

  • API Changed: An API was changed in such a way that code that has not been updated is guaranteed to throw an exception.
  • Behavior Changed: The behavior of Electron has changed, but not in such a way that an exception will necessarily be thrown.
  • Default Changed: Code depending on the old default may break, not necessarily throwing an exception. The old behavior can be restored by explicitly specifying the value.
  • Deprecated: An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.
  • Removed: An API or feature was removed, and is no longer supported by Electron.

Planned Breaking API Changes (34.0)

Deprecated: level, message, line, and sourceId arguments in console-message event on WebContents

The console-message event on WebContents has been updated to provide details on the Event argument.

// Deprecated
webContents.on('console-message', (event, level, message, line, sourceId) => {})
// Replace with:
webContents.on('console-message', ({ level, message, lineNumber, sourceId, frame }) => {})

Additionally, level is now a string with possible values of info, warning, error, and debug.

Planned Breaking API Changes (33.0)

Behavior Changed: frame properties may retrieve detached WebFrameMain instances or none at all

APIs which provide access to a WebFrameMain instance may return an instance with frame.detached set to true, or possibly return null.

When a frame performs a cross-origin navigation, it enters into a detached state in which it's no longer attached to the page. In this state, it may be running unload handlers prior to being deleted. In the event of an IPC sent during this state, frame.detached will be set to true with the frame being destroyed shortly thereafter.

When receiving an event, it's important to access WebFrameMain properties immediately upon being received. Otherwise, it's not guaranteed to point to the same webpage as when received. To avoid misaligned expectations, Electron will return null in the case of late access where the webpage has changed.

... (truncated)

Commits
  • 777d447 fix: software compositing infinite loop (#44352)
  • e0d14a6 build: fixup reclient use for prod builds (#44342)
  • 739df86 fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44324)
  • 9a087b9 chore: fixup reclient read only access on forks (#44304)
  • 8b3f2c5 fix: trace-startup crashing child process on macOS (#44276)
  • ad9bf6b fix: Linux crash after webContents.print() with no parent window (#44285)
  • 32822cd build: remove dead code in prepare release script (#44289)
  • e1419b2 fix: ensure utilityProcess only emits one 'exit' event (#44266)
  • 11c2b61 chore: bump chromium to 130.0.6723.59 (33-x-y) (#44271)
  • 6b458c7 fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (#44260)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 28, 2024
@natalialuzuriaga natalialuzuriaga changed the base branch from main to dev October 31, 2024 19:27
@natalialuzuriaga
Copy link
Collaborator

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 31, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@natalialuzuriaga
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot changed the base branch from dev to main October 31, 2024 22:05
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/electron-33.0.2 branch from 0018977 to d63287b Compare October 31, 2024 22:05
@natalialuzuriaga natalialuzuriaga changed the base branch from main to dev October 31, 2024 22:06
@natalialuzuriaga
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot changed the base branch from dev to main October 31, 2024 22:07
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/electron-33.0.2 branch from d63287b to 6b37627 Compare October 31, 2024 22:07
@natalialuzuriaga natalialuzuriaga changed the base branch from main to dev October 31, 2024 22:11
@natalialuzuriaga
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot changed the base branch from dev to main October 31, 2024 22:17
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/electron-33.0.2 branch from 0310f65 to 31ba10b Compare October 31, 2024 22:17
Bumps [electron](https://github.com/electron/electron) from 28.0.0 to 33.0.2.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v28.0.0...v33.0.2)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/electron-33.0.2 branch from 31ba10b to 8d7b83a Compare October 31, 2024 22:22
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result of the major version update, they deprecated the path field so instead I had to grab the file path using webUtils.getPathForFile(). Tested and it all LGTM!

Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, there was a linting warning so I fixed. LGTM^^^^

@natalialuzuriaga natalialuzuriaga merged commit eb5917e into main Oct 31, 2024
8 of 9 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/frontend/electron-33.0.2 branch October 31, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant