-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump electron from 28.0.0 to 33.0.2 in /frontend #188
Bump electron from 28.0.0 to 33.0.2 in /frontend #188
Conversation
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
0018977
to
d63287b
Compare
@dependabot rebase |
d63287b
to
6b37627
Compare
@dependabot recreate |
0310f65
to
31ba10b
Compare
Bumps [electron](https://github.com/electron/electron) from 28.0.0 to 33.0.2. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v28.0.0...v33.0.2) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
31ba10b
to
8d7b83a
Compare
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a result of the major version update, they deprecated the path
field so instead I had to grab the file path using webUtils.getPathForFile()
. Tested and it all LGTM!
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, there was a linting warning so I fixed. LGTM^^^^
Bumps electron from 28.0.0 to 33.0.2.
Release notes
Sourced from electron's releases.
... (truncated)
Changelog
Sourced from electron's changelog.
... (truncated)
Commits
777d447
fix: software compositing infinite loop (#44352)e0d14a6
build: fixup reclient use for prod builds (#44342)739df86
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44324)9a087b9
chore: fixup reclient read only access on forks (#44304)8b3f2c5
fix: trace-startup crashing child process on macOS (#44276)ad9bf6b
fix: Linux crash afterwebContents.print()
with no parent window (#44285)32822cd
build: remove dead code in prepare release script (#44289)e1419b2
fix: ensureutilityProcess
only emits one 'exit' event (#44266)11c2b61
chore: bump chromium to 130.0.6723.59 (33-x-y) (#44271)6b458c7
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (#44260)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)