Update getColumnsFromDataset endpoint to SST #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkir0003
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
good work on this @noah-iversen . thanks for the detailed testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update getColumnsFromDataset endpoint to SST
Github Issue Number Here: #980
What user problem are we solving?
Users can now read and select the the parsed columns from their uploaded dataset.
What solution does this PR provide?
This solution changes the URL for the getColumnsFromDataset GET request to point to our new SST endpoint that handles parsing for user uploaded files.
Testing Methodology
Tested upload/file read with two different CSV files that had designated column names. I examined network logs and response codes while doing so, everything seems to be fine. See video below.
video1214385438.mp4
Any other considerations
Apparently when running a PUT request for the presigned URL upload, the body must contain the raw file data itself and not as FormData. This important to keep note for future presigned URL uploads. The documentation I found through Googling didn't really mention this (thanks ChatGPT for the help).