Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucas part2 #1046

Closed
wants to merge 6 commits into from
Closed

Lucas part2 #1046

wants to merge 6 commits into from

Conversation

LuHG18
Copy link
Collaborator

@LuHG18 LuHG18 commented Oct 31, 2023

Title of Pull Request HERE

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)>
What user problem are we solving?

What solution does this PR provide?

Testing Methodology

How did you test your changes and verify that existing
functionality is not broken

Any other considerations

@LuHG18 LuHG18 requested a review from a team as a code owner October 31, 2023 22:52
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.2% 0.2% Duplication

Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@karkir0003
Copy link
Member

@LuHG18 can you fix the build check failure and attach screen recording showing your part 2 works as intended

@LuHG18
Copy link
Collaborator Author

LuHG18 commented Nov 7, 2023 via email

@LuHG18 LuHG18 closed this Nov 8, 2023
@karkir0003
Copy link
Member

LucasGoldfarb.mov https://drive.google.com/file/d/1iuz_NByOislHfd_mKj8H1TAn7_3sO5b6/view?usp=drive_web Hi Karthik, Sorry for the delay. I'll try to fix the build check failure before tomorrow but if not I may need some assistance. Thanks. See you tomorrow. Best, Lucas Goldfarb M: (321) 339-7133 E: @.***

On Fri, Nov 3, 2023 at 10:13 AM karkir0003 @.> wrote: @LuHG18 https://github.com/LuHG18 can you fix the build check failure and attach screen recording showing your part 2 works as intended — Reply to this email directly, view it on GitHub <#1046 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCC6LXDTAU2TDPBSMIVZTDYCT3ZRAVCNFSM6AAAAAA6YOE73KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGUYTENBQHE . You are receiving this because you were mentioned.Message ID: @.>

@LuHG18 access request sent

@LuHG18
Copy link
Collaborator Author

LuHG18 commented Nov 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants