-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify github actions to push to aws #1182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweep: PR ReviewSweep is currently reviewing your pr... |
andrewpeng02
force-pushed
the
andrew-deploy-to-aws
branch
from
May 15, 2024 15:22
45e1c45
to
94a97ca
Compare
andrewpeng02
force-pushed
the
andrew-deploy-to-aws
branch
from
May 17, 2024 00:50
a39aa8d
to
af037d7
Compare
@andrewpeng02 is there a short video you can attach to demo the testing? |
karkir0003
reviewed
May 17, 2024
karkir0003
reviewed
May 17, 2024
karkir0003
reviewed
May 17, 2024
karkir0003
reviewed
May 17, 2024
karkir0003
reviewed
May 17, 2024
karkir0003
reviewed
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few questions
andrewpeng02
force-pushed
the
andrew-deploy-to-aws
branch
5 times, most recently
from
May 17, 2024 02:54
20c58fd
to
cb0331b
Compare
andrewpeng02
force-pushed
the
andrew-deploy-to-aws
branch
from
May 17, 2024 02:57
cb0331b
to
fa6a423
Compare
Quality Gate passedIssues Measures |
karkir0003
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify github actions to push training and django containers to AWS
Github Issue Number Here: #1136
What user problem are we solving?
Following #1136 , we want to ensure that we can push the django docker container to the ECS fargate service
django
, and push the training docker container to the ECS servicetraining
with EC2 launch typeWhat solution does this PR provide?
I modified the Terraform plan and github actions slightly
Testing Methodology
dlp-terraform/ecs
, runterraform apply
, ensuring the name of your AWS profile is set correctly inmain.tf
next.config.js
serverless
, runAWS_PROFILE=dlp pnpm run dev
ENVIRONMENT=production dlp-cli frontend start
locally. If the env var is set, it proxies requests to AWSScreen.Recording.2024-05-16.at.9.54.57.PM.mov
Any other considerations
None