Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

central backend check yml file #971

Merged
merged 53 commits into from
Sep 24, 2023
Merged

Conversation

karkir0003
Copy link
Member

@karkir0003 karkir0003 commented Sep 19, 2023

Central Backend Check YML File

What user problem are we solving?
As a part of the Github Action Revamp project, our goal is to centralize our Github Actions build checks ("CI" aspect) for frontend, backend, serverless along with our automated deploy actions to AWS (the "CD" aspect)

What solution does this PR provide?
This PR aims to centralize our backend checks into a backend.yml file. The action is structured such that the lint job runs before the test job in order to optimize on runtime.

Testing Methodology
Tested that the Github Action runs successfully in the ubuntu host.
https://github.com/DSGT-DLP/Deep-Learning-Playground/actions/runs/6255227149/job/16984225135

Any other considerations
Poetry env isn't getting cached properly with micromamba setting. We should somehow fix this in a followup PR.

We should also delete the following yml files in a followup PR as they've been migrated to backend.yml

  • black.yml
  • python-static-checker.yml
  • python-package-poetry.yml

@karkir0003 karkir0003 marked this pull request as ready for review September 20, 2023 23:46
.github/workflows/backend.yml Outdated Show resolved Hide resolved
.github/workflows/backend.yml Outdated Show resolved Hide resolved
.github/workflows/backend.yml Outdated Show resolved Hide resolved
@karkir0003 karkir0003 requested a review from a team as a code owner September 23, 2023 23:03
@karkir0003
Copy link
Member Author

@karkir0003 karkir0003 linked an issue Sep 24, 2023 that may be closed by this pull request
Copy link
Contributor

@dwu359 dwu359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karkir0003
Copy link
Member Author

@dwu359 merging it in! Thanks for the swift review

@karkir0003 karkir0003 added this pull request to the merge queue Sep 24, 2023
Merged via the queue into nextjs with commit 362ee45 Sep 24, 2023
5 checks passed
@karkir0003 karkir0003 deleted the backend-central-build-check branch September 24, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Mamba + Poetry in backend check Github Action
2 participants