-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
central backend check yml file #971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwu359
reviewed
Sep 21, 2023
Sample Github Action run with cache working: https://github.com/DSGT-DLP/Deep-Learning-Playground/actions/runs/6287297625/job/17071660124 |
dwu359
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dwu359 merging it in! Thanks for the swift review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Central Backend Check YML File
What user problem are we solving?
As a part of the Github Action Revamp project, our goal is to centralize our Github Actions build checks ("CI" aspect) for frontend, backend, serverless along with our automated deploy actions to AWS (the "CD" aspect)
What solution does this PR provide?
This PR aims to centralize our backend checks into a backend.yml file. The action is structured such that the lint job runs before the test job in order to optimize on runtime.
Testing Methodology
Tested that the Github Action runs successfully in the ubuntu host.
https://github.com/DSGT-DLP/Deep-Learning-Playground/actions/runs/6255227149/job/16984225135
Any other considerations
Poetry env isn't getting cached properly with micromamba setting. We should somehow fix this in a followup PR.
We should also delete the following yml files in a followup PR as they've been migrated to backend.yml
black.yml
python-static-checker.yml
python-package-poetry.yml