SST file upload #978
Merged
SST file upload #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkir0003
reviewed
Sep 22, 2023
karkir0003
reviewed
Sep 22, 2023
karkir0003
reviewed
Sep 22, 2023
There was a problem hiding this comment.
left a minor comment + question @farisdurrani @dwu359 thoughts?
farisdurrani
approved these changes
Sep 22, 2023
karkir0003
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SST File Upload
Issue #917
What user problem are we solving?
Users can now successfully upload their own files.
What solution does this PR provide?
Utilizes the new SST endpoint for users to upload to. SST endpoint responds with presigned url that they then upload to.
Testing Methodology
Verified network and console logs to ensure proper endpoints are being called. Default option and user upload option works. See video.
Any other considerations
This only covers the upload part, the file uploaded cannot be parsed yet because that given endpoint is old.
video1025155166.mp4