WIP: Improvements in SUBSTOR-Potato model #421
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PT_OPGROW contols the output stage of simulation and write results to the output file. Since we are interested in storing the DTT value as well, pass it as an argument to the PT_OPGROW subroutine.
Use the format F4.2 for DTT output to the file which means it is a 4 digit floating point number and there are 2 digits after the decimal. Also some of the calls to PT_OPGROW were missing DTT in the subroutine argument resulting in crashes.
Break the line down into less than 72 characters wide to fix compilation error. See the link https://stackoverflow.com/a/1947394
The value of CUMDTT was not being passed as an argument at the PT_OPGROW call site.
The DAYL information is stored in the WeatherType variable. Add changes to enable passing the DAYL data from the weather variable to the PT_BTHTIME subroutine. Also mapped the DSSAT's ISTAGE values for different growth stages to the PT_BTHTIME's DS (develpment stage) value range of 0-to-1.
Corrected STT and CUMSTT in the PT_BTHTIME. Corrected the header formating in PT_OPGROW. Added the STT and CUMSTT at call points.
Corrected value 0.079 in STT equation in PT_THTIME. Calculated and added values of SBD, SOD, SCD, and SSEN in the STT calculation in BT_THTIME.
Added comments in the PT_PHENOL regarding calculation of STT cardinal temperatures.
Added remarks about assuming DIF as zero in PT_PHENOL. Also explained variables SBD, SOD, SCD, SSEN in PT_BTHTIME
The variable SD was essentially same as TD so no need to introduce a new variable and use TD instead. Also instead of having two separate loops, the SDU can be calculated using the existing loop for air TDU calculation.
Also remove the Gecross's DS reference and use the DSSAT's internal ISTAGE variable for growth stage.
Add some more helpful information to the commit.
…BGR (potential tuber growth rate) AS both ETGT and STT are the same. Removed redundant lines for calculating the ETGT as no need. STT is already calculated in PT_THTIME or BT_THTIME
Move the newly added parameters i.e. DTT, CUMDTT, STT, CUMSTT, and DAYL to the end of the PlantGro.OUT file to make it compatible with the existing plotting tools.
Added a new subroutine PT_MATURITY that calculates the tuber maturity and return maturity date, WMAX and tuber intitiation date based on the beta method. Signed-off-by: Muhammad Sohail Khan <sohail.wur@gmail.com>
Signed-off-by: Muhammad Sohail Khan <sohail.wur@gmail.com>
… thermal time output
…ted by Griffin et al., 1993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a work in progress and requires cleanup.