Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] : shadowing on plugin property #430

Merged
merged 2 commits into from
Apr 6, 2024
Merged

[FIX] : shadowing on plugin property #430

merged 2 commits into from
Apr 6, 2024

Conversation

nicholass003
Copy link

Please make sure your pull request complies with these guidelines:

    • Use same formatting
    • Changes must have been tested on PMMP.
    • Unless it is a minor code modification, you must use an IDE.
    • Have a detailed title.

What does the PR change?

Resolve:

  • Error: Type of DaPigGuy\PiggyCustomEnchants\commands\CustomEnchantsCommand::$plugin must be pocketmine\plugin\Plugin (as in class CortexPE\Commando\BaseCommand)

Testing Environment

  • PHP: 8.2
  • PMMP: 5.13.0
  • OS: Windows

Extra Information

DaPigGuy
DaPigGuy requested changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@DaPigGuy DaPigGuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Commando version downloaded to fix CI

@nicholass003 nicholass003 requested a review from DaPigGuy April 5, 2024 15:08
DaPigGuy
DaPigGuy approved these changes Apr 6, 2024
View reviewed changes
Copy link
Owner

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaPigGuy DaPigGuy merged commit b815968 into DaPigGuy:PM5 Apr 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholass003 @DaPigGuy