GLSL cleanup: make var_FadeDepth a scalar #1338
Conversation
| // to window coordinates [0, 1] | ||
| float fadeDepth = 0.5 * var_FadeDepth + 0.5; | ||
|
|
||
| // HACK: the (distance from triangle to object behind it) / (shader's depthFade distance) ratio |
There was a problem hiding this comment.
Why not linearize it then? I assume the different fading based on near/far plane etc. is not intended.
There was a problem hiding this comment.
Seemed like more effort than it's worth since I would have to plumb through the near/far values (which can apparently be different for every view) with a uniform. There's an r_zNear GLSL define, but it seems to have a tenuous (at best) connection with the value which is actually used.
There was a problem hiding this comment.
Yeah, zFar is supposed to cover the whole map in whatever direction, while zNear can change for portals. depthtile1_vp does this, albeit with r_zNear, but if it's discreet enough then it's fine as is I guess.
Divide out the w coordinate in the vertex shader instead of the fragment shader. Also add comment about hacky depth fraction calc.
slipher
force-pushed
the
depthfade-cleanup
branch
from
1e22fe7
to
45667ba
Compare
|
Retargeted this to 0.55 to avoid future merge conflicts. |
Divide out the w coordinate in the vertex shader instead of the fragment shader.
Also add comment about hacky depth fraction calc.