Fix entity baseline overflow #1427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that currently, servers can already work around the issue using #1322 which will allow these to load at the cont of high ping players getting a little bit of lag when they see these ents assuming they are in the baseline. Also see #1321 for some prior art on this topic on why the concept of the baseline is problematic to begin with. Indeed this might improve the situation, but is it worth it when we have a workaround? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split net messages if there are too many baselines. I don't like the solution too much because it only works for this exact issue, but I guess it'll do.
The layouts in https://users.unvanquished.net/~reaper/maps/layouts/spacetracks/ can be used to test this with map
spacetracks.Fixes Unvanquished/Unvanquished#2124.