-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for Linux, MinGW and macOS #47
Conversation
edbbe38
to
f1ecfbe
Compare
The PR includes #46 to fix the macOS build: |
4e85b6d
to
ab2a887
Compare
The codeql/appveyor changes were merged: The snprintf fixes were merged: The MinGW fixes are now living in a separate PR: What is now remaining from this PR is the Azure Pipeline configuration. |
ff25f12
to
6f58b19
Compare
d8c780e
to
aceaa37
Compare
b25332b
to
22e8863
Compare
b2e7a72
to
5c702dc
Compare
Except black.jpg and unvanquished_64.png, the test images come from: - https://github.com/UnvanquishedAssets/UnvanquishedTestAssets/tree/master/pkg/map-test-pngalpha_src.dpkdir/textures/test-pngalpha_custom_src - https://gitlab.com/illwieckz/investigating-tga-orientation-in-imagemagick/-/tree/master/samples-default - https://gitlab.com/illwieckz/investigating-tga-orientation-in-imagemagick/-/tree/master/samples I'm the author of all of them and I place them under CC0 1.0 (public domain).
6aa5713
to
3c05088
Compare
I added some PNG, BMP and TGA test images from:
When running the Azure CI on a native platform (no cross-compilation), it runs crunch with them as input. Currently, the test doesn't verify the output of crunch, but it already checks that the input format is not refused, and would catch this kind of error: It also makes us able to run the test outside the CI and it makes me discover the raw TGA input format is not fully supported (horizontal orientation bit is ignored), I guess the error is in STB and then I would have to report them the error. |
13db8a9
to
f8a28ba
Compare
a5f7dc2
to
7e6dde7
Compare
So, now Linux amd64, macOS amd64 and Windows/MSVC run the tests. The tests are only about running crunch on a set of images and only to check that crunch doesn't error out. We may do some checksums later but that's good enough for now and it's enough to validate the infrastructure is there. |
For some unknown reason, when running in azure pipeline, |
ac0b0ed
to
668fff3
Compare
CI for Linux, MinGW and macOS