Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize the system-specific function shims like snprintf #54

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Factorize the system-specific function shims like snprintf #54

merged 7 commits into from
Jul 5, 2024

Conversation

illwieckz
Copy link
Member

  • do not reuse Windows name as alias on non-Windows system,
  • do not re-implement functions there is a system implementation for,
  • deduplicate implementations for things like stricmp,
  • avoid doing ifdef everywhere.

@illwieckz illwieckz changed the title factorize the system-specific function shims like snprintf Factorize the system-specific function shims like snprintf Jul 5, 2024
@slipher
Copy link
Member

slipher commented Jul 5, 2024

LGTM

@illwieckz illwieckz merged commit 749cc2f into master Jul 5, 2024
3 checks passed
@illwieckz illwieckz deleted the illwieckz/snprintf branch July 5, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illwieckz @slipher