crnlib: do not call sem_destroy on macOS
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, sem_unlink should be used instead of sem_destroy, what the current code does is to call sem_destroy on every pthread-compatible system and then call sem_unlink on macOS. It is expected the only macOS implementation of it and other functions like sem_init is to do nothing but to exist and be marked as deprecated so the compiler can print warnings as the -Wdeprecated-declarations flag is enabled by default. Because sem_destroy is expected to be a stub on macOS and we call sem_unlink anyway, the current code works but raises a “'sem_destroy' is deprecated” warning at build time for something we don't need and we already have the right implementation done anyway.
DolceTriade
approved these changes
Jul 4, 2024
illwieckz
force-pushed
the
illwieckz/macos-sem
branch
from
d1e448e
to
a29a99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS,
sem_unlinkshould be used instead ofsem_destroy, what the current code does is to callsem_destroyon every pthread-compatible system and then callsem_unlinkon macOS.It is expected the only macOS implementation of it and other functions like
sem_initis to do nothing but to exist and be marked as deprecated so the compiler can print warnings as the-Wdeprecated-declarationsflag is enabled by default.Because
sem_destroyis expected to be a stub on macOS and we callsem_unlink anyway, the current code works but raises a “'sem_destroy' is deprecated” warning at build time for something we don't need and we already have the right implementation done anyway.