-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make examples multiplatform #58
Conversation
f731530
to
7dc4898
Compare
9b707e7
to
a0b82ef
Compare
I needed to add the For unknown reasons the build of crnlib/crunch was completing itself before without the flag but that's wrong, maybe some libs required by crnlib already implicitly required pthread. |
a0b82ef
to
305d3f1
Compare
CMakeLists.txt
Outdated
@@ -121,7 +121,9 @@ else() | |||
endif() | |||
endif() | |||
|
|||
if (BUILD_SHARED_LIBCRN OR BUILD_STATIC_LIBCRN OR BUILD_CRUNCH) | |||
if (BUILD_SHARED_LIBCRN OR BUILD_STATIC_LIBCRN OR BUILD_CRUNCH OR BULD_EXAMPLES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"BULD_EXAMPLES"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Fixed.
305d3f1
to
60967ae
Compare
Now the examples build everywhere, not only on Windows.
I introduced some
ifdef
that may later be rewritten with deeper change by calling into some already implemented multiplatform functions from crnlib, or to implement such reusable multiplatform function, or to make them reusable, but I expect to do that in a second step, the same way I factorized the snprintf code after having made sure it was right.