Home

Welcome to the gn-standalone-mirror wiki!

Notes to submit patch to Chromium as an external contributor

1 Process

Follow the steps at https://www.chromium.org/developers/contributing-code#TOC-Uploading-a-change-for-review.

2 Summary

a) Register as contributor following the "Legal stuff".

b) Checkout chromium source code

https://www.chromium.org/developers/how-tos/get-the-code

c) Make your patch ready in a local branch

d) Upload your patch for review

e) Code review & updates

Normally prepare and submit your patches in one single source checkout. In cases of multiple checkouts in multiple OSes, run "git cl issue TicketNumber" to reuse the same ticket number before patch submissions. Otherwise, new review ticket will be issued for your new patch instead of being put into your existing review ticket.

f) Running automated tests

If you do not have commit right, the reviewer will be and need to be the one that triggers the test build run before that patch can be released to the Chromium source tree.

f) Patch accepted and merged into Chromium source tree

Ref:

1. Do contribute your patch at https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/EJw9PehAIgc.
2. Chromium review process: update patch at https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/gsv9haov8fA
3. GN bootstrap patch at https://chromium-review.googlesource.com/c/chromium/src/+/611776