Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package refactoring #12

Merged
merged 23 commits into from
Aug 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a162bf7
Establish package structure
DanielKotik Aug 4, 2021
5b76333
Move `critical` and `brewster` functions top level
DanielKotik Aug 4, 2021
3fbd04d
Add helper modules containing private functions used internally
DanielKotik Aug 4, 2021
8d39980
Add `beams.py` holding beam class definitions
DanielKotik Aug 4, 2021
6db65d0
Add helper functions to `_helpers:py`
DanielKotik Aug 6, 2021
8900d69
Add beam classes to `beams.py`
DanielKotik Aug 6, 2021
6ff057e
Fix imports for 2d subpackage
DanielKotik Aug 11, 2021
345699b
Fix imports for 3d subpackage
DanielKotik Aug 11, 2021
1c9d70c
Rename subpackage names to be valid identifiers:
DanielKotik Aug 12, 2021
8d2dfc3
Import only necessary functions and classes:
DanielKotik Aug 12, 2021
ba1d89a
Avoid circular import of `Beam3d` class
DanielKotik Aug 12, 2021
96e8ae0
Introduce abstract base class `Beam2d`:
DanielKotik Aug 12, 2021
a3cd99e
Avoid circular import of `Beam2d` class
DanielKotik Aug 12, 2021
670053b
Remove `optbeam.py` files from script folders
DanielKotik Aug 12, 2021
34a4213
Move beam specific folders with scripts into separate `scripts` folder
DanielKotik Aug 12, 2021
4b364ad
Remove duplicate Cython entry in `.gitignore`
DanielKotik Aug 12, 2021
885fde9
Add version string to `__init__.py`
DanielKotik Aug 14, 2021
f72946e
Add `setup.py`
DanielKotik Aug 14, 2021
3fb40be
Make availability of module `cython` completly optional for now
DanielKotik Aug 15, 2021
1a3b3fa
Rename `_helpers.py` to `helpers.py`:
DanielKotik Aug 15, 2021
9f47ee2
Update `.gitignore`
DanielKotik Aug 15, 2021
e31bf65
Remove Cython implementation files in script folders:
DanielKotik Aug 15, 2021
6aacf94
Update `README.md`
DanielKotik Aug 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
Airy_2d/Airy2d-out/*
Laguerre_Gauss_3d/LaguerreGauss3d-out/*
Gauss_2d/planar/*
Gauss_2d/concave/*
Gauss_2d/convex/*
scripts/Airy_2d/Airy2d-out/*
scripts/Laguerre_Gauss_3d/LaguerreGauss3d-out/*
scripts/Gauss_2d/planar/*
scripts/Gauss_2d/concave/*
scripts/Gauss_2d/convex/*

### Jupyter ###
.ipynb_checkpoints
*/.ipynb_checkpoints/*

### Cython ###
Laguerre_Gauss_3d/optbeam.c
Laguerre_Gauss_3d/optbeam.html

### Python ###
# Byte-compiled / optimized / DLL files
__pycache__/
Expand Down Expand Up @@ -124,3 +120,6 @@ dmypy.json

# Pyre type checker
.pyre/

# Virtual environment created via python -m venv optbeam-env
optbeam-env
58 changes: 0 additions & 58 deletions Airy_2d/optbeam.pxd

This file was deleted.

229 changes: 0 additions & 229 deletions Airy_2d/optbeam.py

This file was deleted.

55 changes: 0 additions & 55 deletions Gauss_2d/optbeam.pxd

This file was deleted.

Loading