Skip to content

Commit

Permalink
chore: handle warnings in build pipeline (#127)
Browse files Browse the repository at this point in the history
* handle warnings in build

* another warning

* and last one from build
  • Loading branch information
DeagleGross authored Sep 13, 2024
1 parent d2bb973 commit 0b5f6d7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/dotnet-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,16 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0 # depth is needed for nbgv

- name: Setup .NET
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
6.0.x
8.0.x
include-prerelease: true
8.0.x
- name: Build
run: dotnet build Dapper.AOT.sln -c Debug
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,16 @@ jobs:
runs-on: windows-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0 # depth is needed for nbgv

- name: Setup .NET
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
6.0.x
8.0.x
include-prerelease: true
- uses: dotnet/nbgv@master
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ public class DbStringPoco
public const string TableName = "dbStringPoco";

public int Id { get; set; }
public string Name { get; set; }
public string? Name { get; set; }
}
3 changes: 2 additions & 1 deletion test/Dapper.AOT.Test.Integration/DbStringTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public void DbString_BasicUsage_InterceptsAndReturnsExpectedData()
{
var result = ExecuteInterceptedUserCode<DbStringUsage, DbStringPoco>(DbConnection);

Assert.NotNull(result);
Assert.True(result.Id.Equals(1));
Assert.True(result.Name.Equals("my-dbString", StringComparison.InvariantCultureIgnoreCase));
Assert.Equal("my-dbString", result.Name);
}
}

0 comments on commit 0b5f6d7

Please sign in to comment.