Dynamically check missing data in points #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as produced when pulling data that does not have the 'quantity' object in the point structure (for example DayAheadPrices). This should now be fixed
|
Add a test. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dario
Thank you for accepting my last pull request. Unfortunately, another change slipped into the same pull request yesterday shortly before your merge (checks for missing positions). This change had not yet been sufficiently tested and was therefore incorrect.
This pull request fixes this error.
In the API response, it can happen that only one value is sent if the same value occurs twice in succession. Example: [{'position': 1, 'quantity': 500}, {'position': 3, 'quantity': 450}]. In this case, position 1 and 2 have the same 'quantity', but position 2 is not returned (see screenshot).
The parser now checks whether there are gaps in the positions and if so, these gaps are filled with the previous value. If values are missing at the end (and no positions are missing), the last value for the missing positions is appended.
I hope this change meets your expectations and I apologize again that my first pull request was faulty.
Best regards