-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make particles solid squares when cl_particles_quake is set to 2 #137
Make particles solid squares when cl_particles_quake is set to 2 #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one adds a few minor warns that should be easy to fix, we currently have no warns (at least on linux with gcc 13.2 or clang 14) so if you see one it's probably yours :) gcc seems more rigorous than clang when it comes to catching issues. Also CONTRIBUTING.md style please.
I have a feeling that if we remove the current behaviour of Edit: I haven't looked at what other engines are doing here, or if there is one that offers 3 particle styles. |
QuakeSpasm has OpenGL disc particles, and Ironwail allows the option of OpenGL discs or Quake squares. |
Signed-off-by: bones_was_here <bones_was_here@xonotic.au>
This creates a new function,
CL_NewQuakeParticle
, that is used instead ofCL_NewParticle
whencl_particles_quake
is enabled. The function callsCL_NewParticle
with a some hardcoded defaults to make the particle texture a disc, or solid square, based on the value ofcl_particles_quake
.Possibly also resolves https://gitlab.com/xonotic/darkplaces/-/issues/308 by re-implementing the colour ramp mechanic for explosion particles.