Improve glsl shader performance #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Riiight, forgot to rebase. |
Use fragment depth from built-in gl_FragCoord instead of our own depth attribute
Adds few fps. Function seems to be too complex for my understanding.
Saturated sum of positive values is equal to saturated sum of saturated values
|
There is room for improvement, for example texture matrix, but it will require changing rendering code, so it will not be here for sake of simplicity. |
hemebond
approved these changes
Oct 20, 2024
divVerent
approved these changes
Oct 25, 2024
I've tested it with Quake. I didn't notice any problems. @uis246 if there's any in particular that might be affected please let me know. |
|
I've used only properties of linear algebra(like elements of normalized vector are always in range of [-1, 1]), basic arithmetics, shuffling between registers, using proper built-ins instead of hacks and assumption of samples being in range of [0, 1]. Seems to be it. |
|
So there should be no existing game being affected |
divVerent
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most optimizations are done by abusing mathematical properties and replacing slow on some hardware(e.g. Inetl) min and max with saturation.
For example dot product is in range [-1, 1], so
max(0, dot(...))=sat(dot(...)).In places where this potentially can mess with HDR comments were added.