Merge branch 'develop'

Data-swift · Oct 7, 2023 · 40e531d · 40e531d
2 parents 1530d28 + 768502f
commit 40e531d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/Sources/ManagedModels/PersistentModel/PersistentModel+KVC.swift b/Sources/ManagedModels/PersistentModel/PersistentModel+KVC.swift
@@ -31,7 +31,15 @@ public extension PersistentModel {
     where T: Codable & CoreDataPrimitiveValue & AnyOptional
   {
     willChangeValue(forKey: key); defer { didChangeValue(forKey: key) }
-    setPrimitiveValue(value, forKey: key)
+
+    // While `nil` is properly bridged to `NSNull`, this is still necessary
+    // because `T` is the Optional structure, NOT the value type. I think :-)
+    if value.isSome {
+      setPrimitiveValue(value.value, forKey: key)
+    }
+    else {
+      setPrimitiveValue(nil, forKey: key)
+    }
   }
   @inlinable
   func getValue<T>(forKey key: String) -> T

diff --git a/Tests/ManagedModelTests/CoreDataAssumptionsTests.swift b/Tests/ManagedModelTests/CoreDataAssumptionsTests.swift
@@ -67,4 +67,20 @@ final class CoreDataAssumptionsTests: XCTestCase {
     XCTAssertEqual(relationship.isOrdered, copiedRelationship.isOrdered)
     XCTAssertEqual(relationship.maxCount, copiedRelationship.maxCount)
   }
+
+
+  func testAttributeValueClassIsNotEmpty() throws {
+    do {
+      let attribute = NSAttributeDescription()
+      attribute.name = "Hello"
+      attribute.attributeType = .stringAttributeType
+      XCTAssertEqual(attribute.attributeValueClassName, "NSString")
+    }
+    do {
+      let attribute = NSAttributeDescription()
+      attribute.name = "Hello"
+      attribute.attributeType = .integer16AttributeType
+      XCTAssertEqual(attribute.attributeValueClassName, "NSNumber")
+    }
+  }
 }