Add support for transformable property types #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
@Attribute(.transformed(by: Transformer.self))
property as per issue #4. This only adds support for type specified Transformers inheriting directly from ValueTransformer.Due to the need of registering the transformer and issues with
NSClassFromString()
the named equivalent of this attributed was not implemented as part of this PR.Additionally when testing the implementation, I encountered an error with CodableBox transformer which could be passed a base type T as the value. This was addressed with additional check. Not sure if the reverse transformer should return value of type T or CodableBox then? Although the committed approach with base type T appears to work with my tested model.
Additionally, while adding tests for Transformable properties, I added a test case for RawRepresentable enums.