-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-6567] Generate new web vitals attribution fields #3251
✨ [RUM-6567] Generate new web vitals attribution fields #3251
Conversation
cefc56e
to
3954e43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
==========================================
- Coverage 93.51% 93.50% -0.01%
==========================================
Files 288 288
Lines 7599 7606 +7
Branches 1730 1735 +5
==========================================
+ Hits 7106 7112 +6
- Misses 493 494 +1 ☔ View full report in Codecov by Sentry. |
/to-staging |
Devflow running:
|
/to-staging -c |
Devflow running:
|
/to-staging |
Devflow running:
|
9102f3f
to
6999e09
Compare
/to-staging |
Devflow running:
|
…staging-02 Integrated commit sha: 6999e09 Co-authored-by: Seth Fowler <seth.fowler@datadoghq.com>
/to-staging |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Devflow running:
|
…staging-03 Integrated commit sha: dde4a81 Co-authored-by: Seth Fowler <seth.fowler@datadoghq.com>
OK, I rebased to incorporate the latest changes to the web vitals attribution format. Everything looks good on staging, so I think this is now ready to ship! I'm going to go ahead and merge. |
Motivation
This PR adds code to generate the new web vitals attribution fields that were added to the event format in this PR.
For now, the old web vitals fields remain. To remove them safely without breaking backwards compatibility, we need backend changes, so we'll hold off until those are done.
Changes
rum-events-format
submodule has been updated to include the new fields.viewCollection.ts
.Testing
I have gone over the contributing documentation.