Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USM] Reduce new_dynamic_value_size #21626

Closed
wants to merge 2 commits into from

Conversation

amitslavin
Copy link
Contributor

What does this PR do?

Reduce new_dynamic_value_size in order to decrease program size.

Motivation

The value of the new_dynamic_value_size can be used by only 16 bits.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@amitslavin amitslavin added changelog/no-changelog component/system-probe [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/usm The USM team labels Dec 18, 2023
@amitslavin amitslavin added this to the 7.51.0 milestone Dec 18, 2023
@amitslavin amitslavin requested a review from a team as a code owner December 18, 2023 16:20
@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 7218c15c-4e9f-464a-9268-3c8d33bb90ff
Baseline: 10907e0
Comparison: d4038ff
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput -3.00 [-3.75, -2.26] 100.00%

Declared erratic experiments that are now stable

An experiment is stable (i.e., not erratic) if its coefficient of variation is less than 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
file_tree memory utilization +0.32 [+0.23, +0.42] 100.00%
idle memory utilization +0.05 [+0.03, +0.07] 99.95%

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
file_to_blackhole % cpu utilization +0.57 [-6.08, +7.22] 11.16%
file_tree memory utilization +0.32 [+0.23, +0.42] 100.00%
idle memory utilization +0.05 [+0.03, +0.07] 99.95%
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.05, +0.05] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.04, +0.04] 0.00%
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.05] 0.00%
dogstatsd_string_interner_64MiB_1k ingress throughput -0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput -0.00 [-0.04, +0.04] 0.00%
uds_dogstatsd_to_api ingress throughput -0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_128MiB_1k ingress throughput -0.00 [-0.06, +0.06] 0.00%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.00, +0.00] 0.15%
trace_agent_msgpack ingress throughput -0.03 [-0.05, -0.01] 99.57%
trace_agent_json ingress throughput -0.03 [-0.06, -0.00] 93.23%
tcp_syslog_to_blackhole ingress throughput -0.27 [-0.33, -0.20] 100.00%
otel_to_otel_logs ingress throughput -3.00 [-3.75, -2.26] 100.00%

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@amitslavin
Copy link
Contributor Author

The issue of reducing the instruction limit was handled by #21627 (review)

@amitslavin amitslavin closed this Dec 19, 2023
@dd-devflow dd-devflow bot deleted the amit.slavin/reduce-dynamic-size branch July 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant