Update checkout action version

[pgimalac]

What does this PR do?

Update actions/checkout from v3 to v4.

Motivation

This follows from this comment when creating a workflow. I initially used v3 because most workflows in this repo did so.

Additional Notes

The main change between v3 and v4 was to increase the version of Node the action used.
Release.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• A release note has been added or the changelog/no-changelog label has been applied.
• Changed code has automated tests for its functionality.
• Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
• At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• If applicable, the need-change/operator and need-change/helm labels have been applied.
• If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• If applicable, the config template has been updated.

[pr-commenter]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: c4a5f383-cfae-4c00-a43f-0e8d0979875d
Baseline: c3a2b55
Comparison: d5dc205
Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_tree	memory utilization	+0.09	[-0.01, +0.20]
➖	idle	memory utilization	+0.07	[+0.04, +0.10]
➖	file_to_blackhole	% cpu utilization	-0.86	[-7.39, +5.67]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	otel_to_otel_logs	ingress throughput	+1.29	[+0.52, +2.06]
➖	tcp_syslog_to_blackhole	ingress throughput	+0.22	[+0.16, +0.28]
➖	process_agent_real_time_mode	memory utilization	+0.10	[+0.07, +0.14]
➖	file_tree	memory utilization	+0.09	[-0.01, +0.20]
➖	trace_agent_json	ingress throughput	+0.08	[+0.04, +0.11]
➖	idle	memory utilization	+0.07	[+0.04, +0.10]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.04, +0.04]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.06, +0.06]
➖	trace_agent_msgpack	ingress throughput	-0.05	[-0.08, -0.02]
➖	process_agent_standard_check_with_stats	memory utilization	-0.17	[-0.21, -0.12]
➖	process_agent_standard_check	memory utilization	-0.51	[-0.55, -0.46]
➖	file_to_blackhole	% cpu utilization	-0.86	[-7.39, +5.67]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[github-actions]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between d761a55 and 2b3d299.

tl;dr

1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │   previous    │                 current                  │
                                      │    sec/op     │     sec/op      vs base                  │
api-gateway-appsec.json                  143.5µ ±  3%    142.5µ ±   2%        ~ (p=0.853 n=10)
api-gateway-kong-appsec.json             98.92µ ±  2%   100.59µ ±   3%        ~ (p=0.063 n=10)
api-gateway-kong.json                    95.85µ ±  3%    97.70µ ±   1%        ~ (p=0.089 n=10)
api-gateway-non-proxy-async.json         149.9µ ±  3%    149.5µ ±   1%        ~ (p=0.912 n=10)
api-gateway-non-proxy.json               146.1µ ±  4%    146.3µ ±   2%        ~ (p=0.912 n=10)
api-gateway-websocket-connect.json       96.59µ ±  2%    96.16µ ±   3%        ~ (p=0.247 n=10)
api-gateway-websocket-default.json       81.97µ ±  3%    80.92µ ±   1%        ~ (p=0.143 n=10)
api-gateway-websocket-disconnect.json    81.72µ ±  2%    79.73µ ±   2%   -2.45% (p=0.005 n=10)
api-gateway.json                         164.6µ ±  4%    160.3µ ±   3%        ~ (p=0.052 n=10)
application-load-balancer.json           80.33µ ±  2%    77.47µ ±   3%   -3.57% (p=0.019 n=10)
cloudfront.json                          65.73µ ±  5%    63.76µ ±   4%        ~ (p=0.063 n=10)
cloudwatch-events.json                   48.34µ ±  4%    47.18µ ±   4%        ~ (p=0.631 n=10)
cloudwatch-logs.json                     64.77µ ± 20%    62.86µ ±   6%        ~ (p=0.247 n=10)
custom.json                              34.27µ ± 14%    32.73µ ±   5%        ~ (p=0.063 n=10)
dynamodb.json                            155.3µ ±  8%    145.7µ ±   3%        ~ (p=0.165 n=10)
empty.json                               36.08µ ±  5%    30.10µ ±   7%  -16.59% (p=0.000 n=10)
eventbridge-custom.json                  54.91µ ±  9%    54.11µ ±   4%        ~ (p=0.218 n=10)
http-api.json                           101.57µ ±  6%    88.71µ ±   2%  -12.66% (p=0.002 n=10)
kinesis-batch.json                       116.7µ ±  8%    102.5µ ±   3%  -12.17% (p=0.000 n=10)
kinesis.json                             88.57µ ±  7%    70.23µ ±  11%  -20.70% (p=0.000 n=10)
s3.json                                  96.15µ ± 13%    91.34µ ±   4%        ~ (p=0.063 n=10)
sns-batch.json                           141.2µ ± 11%    132.4µ ±   4%        ~ (p=0.052 n=10)
sns.json                                104.13µ ± 11%    96.34µ ±   7%        ~ (p=0.165 n=10)
snssqs.json                              156.2µ ± 15%    158.4µ ±   8%        ~ (p=0.853 n=10)
snssqs_no_dd_context.json                152.5µ ± 15%    144.2µ ±   6%        ~ (p=0.075 n=10)
sqs-aws-header.json                      96.80µ ± 12%    87.90µ ±   7%        ~ (p=0.089 n=10)
sqs-batch.json                           158.6µ ± 15%    141.5µ ± 175%        ~ (p=0.052 n=10)
sqs.json                                 109.5µ ± 16%    109.3µ ± 337%        ~ (p=0.739 n=10)
sqs_no_dd_context.json                  107.77µ ± 15%    96.18µ ±  13%        ~ (p=0.083 n=10+8)
geomean                                  96.48µ          91.54µ          -5.13%

                                      │   previous    │                current                 │
                                      │     B/op      │     B/op       vs base                 │
api-gateway-appsec.json                 39.97Ki ±  3%   39.96Ki ±  3%       ~ (p=0.870 n=10)
api-gateway-kong-appsec.json            28.03Ki ± 11%   28.95Ki ± 14%       ~ (p=0.643 n=10)
api-gateway-kong.json                   25.45Ki ± 24%   25.45Ki ±  0%       ~ (p=0.381 n=10)
api-gateway-non-proxy-async.json        49.90Ki ±  0%   49.91Ki ±  0%       ~ (p=0.184 n=10)
api-gateway-non-proxy.json              48.46Ki ±  0%   48.46Ki ±  0%       ~ (p=0.782 n=10)
api-gateway-websocket-connect.json      28.69Ki ±  0%   28.69Ki ±  0%       ~ (p=0.617 n=10)
api-gateway-websocket-default.json      22.94Ki ±  0%   22.94Ki ±  0%       ~ (p=0.084 n=10)
api-gateway-websocket-disconnect.json   22.58Ki ±  0%   22.59Ki ±  0%       ~ (p=0.985 n=10)
api-gateway.json                        52.27Ki ±  0%   52.28Ki ±  0%       ~ (p=0.592 n=10)
application-load-balancer.json          23.35Ki ±  0%   23.35Ki ±  0%       ~ (p=0.423 n=10)
cloudfront.json                         18.58Ki ±  0%   18.58Ki ±  0%       ~ (p=0.701 n=10)
cloudwatch-events.json                  12.16Ki ±  0%   12.17Ki ±  0%       ~ (p=0.562 n=10)
cloudwatch-logs.json                    54.13Ki ±  0%   54.13Ki ±  0%       ~ (p=0.513 n=10)
custom.json                             9.696Ki ±  0%   9.693Ki ±  0%  -0.03% (p=0.016 n=10)
dynamodb.json                           41.78Ki ±  0%   41.78Ki ±  0%       ~ (p=0.278 n=10)
empty.json                              9.147Ki ±  0%   9.146Ki ±  0%       ~ (p=0.149 n=10)
eventbridge-custom.json                 13.72Ki ±  0%   13.72Ki ±  0%       ~ (p=0.894 n=10)
http-api.json                           24.18Ki ±  0%   24.17Ki ±  0%  -0.02% (p=0.041 n=10)
kinesis-batch.json                      27.66Ki ±  0%   27.65Ki ±  0%  -0.03% (p=0.000 n=10)
kinesis.json                            18.22Ki ±  0%   18.22Ki ±  0%       ~ (p=0.871 n=10)
s3.json                                 20.72Ki ±  0%   20.72Ki ±  0%       ~ (p=0.378 n=10)
sns-batch.json                          40.84Ki ±  0%   40.84Ki ±  0%       ~ (p=0.926 n=10)
sns.json                                24.96Ki ±  0%   24.96Ki ±  0%       ~ (p=0.986 n=10)
snssqs.json                             43.77Ki ±  0%   43.77Ki ±  0%       ~ (p=0.984 n=10)
snssqs_no_dd_context.json               36.74Ki ±  0%   36.74Ki ±  0%       ~ (p=0.810 n=10)
sqs-aws-header.json                     19.34Ki ±  0%   19.34Ki ±  0%       ~ (p=0.269 n=10)
sqs-batch.json                          42.09Ki ±  0%   42.09Ki ±  0%       ~ (p=0.239 n=10)
sqs.json                                25.88Ki ±  0%   25.89Ki ±  1%       ~ (p=0.836 n=10)
sqs_no_dd_context.json                  20.68Ki ±  0%   20.67Ki ±  0%       ~ (p=0.057 n=10+8)
geomean                                 26.23Ki         26.26Ki        +0.11%

                                      │  previous  │                current                │
                                      │ allocs/op  │ allocs/op   vs base                   │
api-gateway-appsec.json                 464.0 ± 0%   464.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-kong-appsec.json            439.0 ± 0%   439.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-kong.json                   422.0 ± 0%   422.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-non-proxy-async.json        589.0 ± 0%   589.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-non-proxy.json              580.0 ± 0%   580.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-websocket-connect.json      388.0 ± 0%   388.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway-websocket-default.json      318.0 ± 0%   318.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json   313.0 ± 0%   313.0 ± 0%       ~ (p=1.000 n=10)   ¹
api-gateway.json                        640.0 ± 0%   640.0 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json          329.0 ± 0%   329.0 ± 0%       ~ (p=1.000 n=10)   ¹
cloudfront.json                         246.0 ± 0%   246.0 ± 0%       ~ (p=1.000 n=10)   ¹
cloudwatch-events.json                  221.0 ± 0%   221.0 ± 0%       ~ (p=1.000 n=10)   ¹
cloudwatch-logs.json                    211.0 ± 0%   211.0 ± 0%       ~ (p=1.000 n=10)   ¹
custom.json                             172.0 ± 0%   172.0 ± 0%       ~ (p=1.000 n=10)   ¹
dynamodb.json                           413.0 ± 0%   413.0 ± 0%       ~ (p=0.628 n=10)
empty.json                              161.0 ± 0%   161.0 ± 0%       ~ (p=1.000 n=10)   ¹
eventbridge-custom.json                 241.0 ± 0%   241.0 ± 0%       ~ (p=1.000 n=10)   ¹
http-api.json                           379.0 ± 0%   378.5 ± 0%       ~ (p=0.141 n=10)
kinesis-batch.json                      297.0 ± 0%   297.0 ± 0%       ~ (p=0.474 n=10)
kinesis.json                            244.0 ± 0%   244.0 ± 0%       ~ (p=1.000 n=10)   ¹
s3.json                                 282.0 ± 0%   282.0 ± 0%       ~ (p=1.000 n=10)
sns-batch.json                          349.0 ± 0%   348.5 ± 0%       ~ (p=0.650 n=10)
sns.json                                275.0 ± 0%   275.0 ± 0%       ~ (p=1.000 n=10)   ¹
snssqs.json                             333.5 ± 0%   334.0 ± 0%       ~ (p=1.000 n=10)
snssqs_no_dd_context.json               288.0 ± 0%   288.0 ± 0%       ~ (p=1.000 n=10)
sqs-aws-header.json                     239.0 ± 0%   239.0 ± 0%       ~ (p=1.000 n=10)   ¹
sqs-batch.json                          391.0 ± 0%   392.0 ± 0%       ~ (p=0.328 n=10)
sqs.json                                298.0 ± 0%   298.0 ± 1%       ~ (p=0.211 n=10)
sqs_no_dd_context.json                  276.0 ± 0%   276.0 ± 0%       ~ (p=1.000 n=10+8) ¹
geomean                                 319.2        319.2       +0.00%
¹ all samples are equal

[pgimalac]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 45m)

you can cancel this operation by commenting your pull request with /merge -c!