[ASCII-1081] Remove Stop method from demultiplexer interface #22069
Conversation
defer demux.Stop(false) is not needed as done by fx.Hook
ogaca-dd
changed the title
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 95811340-a4e4-456b-9385-076a2aefc92f Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.33 | [-6.23, +6.88] |
| ➖ | idle | memory utilization | -0.15 | [-0.20, -0.11] |
| ➖ | file_tree | memory utilization | -0.76 | [-0.88, -0.63] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.65 | [-0.07, +1.37] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.58 | [-0.88, +2.03] |
| ➖ | file_to_blackhole | % cpu utilization | +0.33 | [-6.23, +6.88] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.03, +0.03] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.06, +0.06] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.04, +0.00] |
| ➖ | trace_agent_json | ingress throughput | -0.03 | [-0.06, +0.00] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.07 | [-0.11, -0.02] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.10 | [-0.15, -0.04] |
| ➖ | idle | memory utilization | -0.15 | [-0.20, -0.11] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.57 | [-0.63, -0.52] |
| ➖ | process_agent_standard_check | memory utilization | -0.59 | [-0.65, -0.53] |
| ➖ | file_tree | memory utilization | -0.76 | [-0.88, -0.63] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
| @@ -24,12 +24,6 @@ import ( | |||
| type Demultiplexer interface { | |||
| // General | |||
| // -- | |||
|
|
|||
| // Run runs all demultiplexer parts | |||
| Run() | |||
There was a problem hiding this comment.
Was the Run method used anywhere ?
There was a problem hiding this comment.
Run is called at https://github.com/DataDog/datadog-agent/blob/7.50.0/pkg/aggregator/demultiplexer_agent.go#L130 and doesn't need to be exported. I have created a commit to not export the function.
| deps.Lc.Append(fx.Hook{OnStop: func(ctx context.Context) error { | ||
| agentDemultiplexer.Stop(true) | ||
| return nil | ||
| }}) |
There was a problem hiding this comment.
Could it change the order in which the components are stopped, similarly to the bug we had a few months ago ?
There was a problem hiding this comment.
Yes, indeed, that is why I added QA instructions and carefully check it is OK to stop the aggregator later.
…/remove-demux-stop
`Stop` is always called when using demultiplexer but NewNoopEventPlatformForwarder() set p.strategy to nil which was not check when calling `Stop`
Serverless Benchmark Results
tl;dr
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
Benchmark stats |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 47m) Use |
|
❌ MergeQueue Tests failed on this commit f336052 You should fix those tests and then re-add your pull request to the queue! Details
checks are failing:
If you need support, contact us on Slack #ci-interfaces with those details! |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 47m) Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: rejected
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
What does this PR do?
This PR removes the
Stopmethod from the demultiplexer interface in favour of using fxOnStophook.This PR must be merged after #22044 to make sure
OnStopon the demultiplexer instance is called even when there is an error.Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Run the command (see below), wait 3-4 seconds (should be less than 10s) and stop the command with
ctrl+c. CheckStopping aggregatoris in the log of the Agent and after you pressctrl+cand there is no panic.Agent shared component
Platform integration:
Open telemetry:
Security Agent:
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.