[ASCII-1277] Remove sub packages from pkg/status. All agents now use the status component #23525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Package Import DifferencesBaseline: c221f83
|
GustavoCaso
changed the title
GustavoCaso
changed the title
GustavoCaso
added
qa/no-code-change
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 03b92485-a58d-4237-9e18-143cd1e46a38 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.68 | [-5.89, +7.25] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.68 | [-5.89, +7.25] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.25 | [+0.20, +0.30] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.12 | [-0.51, +0.75] |
| ➖ | trace_agent_json | ingress throughput | +0.03 | [+0.00, +0.06] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.03, +0.01] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.18 | [-1.62, +1.25] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.36 | [-0.40, -0.33] |
| ➖ | file_tree | memory utilization | -0.46 | [-0.55, -0.37] |
| ➖ | process_agent_standard_check | memory utilization | -0.50 | [-0.54, -0.46] |
| ➖ | basic_py_check | % cpu utilization | -0.60 | [-2.76, +1.56] |
| ➖ | idle | memory utilization | -0.72 | [-0.76, -0.69] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.88 | [-0.94, -0.82] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
louis-cqrl
reviewed
Mar 8, 2024
| otlpStatus.SetOtelCollector(otelcollector) | ||
|
|
||
| return nil | ||
| return otelcollector.Start() |
There was a problem hiding this comment.
otelcollector.Start() does return an error like the previous version ? or it can't fail anymore ?
There was a problem hiding this comment.
I'm not entirely sure what you mean.
Does otelcollector.Start() return an error? Yes
previous version ?
Is there a previous version?
There was a problem hiding this comment.
Okay my bad all okay, I thinks it is all good for me
ogaca-dd
approved these changes
Mar 8, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 28m) Use |
julien-lebot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…the status component (#23525) * Remove subpackages from pkg/status. All agents now use the status component * fix lint issue with unused function * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After all the work done to migrate the different agent to use the status component:
We can remove all the legacy subpakcges of
pkg/status🔥Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes