Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all possible endpoint to diagnose command #24377

Closed

Conversation

louis-cqrl
Copy link
Contributor

What does this PR do?

Add endpoints to diagnose command

Motivation

https://datadoghq.atlassian.net/browse/ASCII-707

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

All old endpoints in datadog-agent diagnose should behave exactly the same as before
All new endpoints in datadog-agent diagnose should succeed

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34558172 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2024

Regression Detector

Regression Detector Results

Run ID: f9909f57-a59e-497a-8eaa-ac8286c2d476
Baseline: 797b120
Comparison: e542628

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.00 [-1.76, +3.75]
file_tree memory utilization +0.88 [+0.77, +1.00]
basic_py_check % cpu utilization +0.51 [-1.97, +2.99]
tcp_syslog_to_blackhole ingress throughput +0.32 [-20.90, +21.55]
otel_to_otel_logs ingress throughput +0.06 [-0.30, +0.41]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.04, +0.04]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.01 [-0.22, +0.19]
idle memory utilization -0.32 [-0.36, -0.28]
pycheck_1000_100byte_tags % cpu utilization -3.18 [-7.65, +1.30]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 46.93878% with 26 lines in your changes missing coverage. Please review.

Project coverage is 55.80%. Comparing base (797b120) to head (e542628).
Report is 3429 commits behind head on main.

Files with missing lines Patch % Lines
pkg/diagnose/connectivity/endpoint_info.go 0.00% 17 Missing ⚠️
pkg/diagnose/connectivity/core_endpoint.go 35.71% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #24377       +/-   ##
===========================================
+ Coverage   44.66%   55.80%   +11.14%     
===========================================
  Files        2281      886     -1395     
  Lines      263602    75424   -188178     
===========================================
- Hits       117726    42093    -75633     
+ Misses     136416    30852   -105564     
+ Partials     9460     2479     -6981     
Flag Coverage Δ
amzn_aarch64 56.66% <46.93%> (+11.21%) ⬆️
centos_x86_64 56.56% <46.93%> (+11.21%) ⬆️
ubuntu_aarch64 56.67% <46.93%> (+11.21%) ⬆️
ubuntu_x86_64 56.67% <46.93%> (+11.23%) ⬆️
windows_amd64 55.27% <46.93%> (+4.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dd-devflow dd-devflow bot closed this Nov 17, 2024
@dd-devflow dd-devflow bot deleted the louis-cqrl/add-all-endpoints-connectivity-diagnose branch November 17, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant