-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all possible endpoint to diagnose command #24377
Add all possible endpoint to diagnose command #24377
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34558172 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: f9909f57-a59e-497a-8eaa-ac8286c2d476 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.00 | [-1.76, +3.75] |
➖ | file_tree | memory utilization | +0.88 | [+0.77, +1.00] |
➖ | basic_py_check | % cpu utilization | +0.51 | [-1.97, +2.99] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.32 | [-20.90, +21.55] |
➖ | otel_to_otel_logs | ingress throughput | +0.06 | [-0.30, +0.41] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.04, +0.04] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.22, +0.19] |
➖ | idle | memory utilization | -0.32 | [-0.36, -0.28] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -3.18 | [-7.65, +1.30] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…y tests in diagnose/README.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24377 +/- ##
===========================================
+ Coverage 44.66% 55.80% +11.14%
===========================================
Files 2281 886 -1395
Lines 263602 75424 -188178
===========================================
- Hits 117726 42093 -75633
+ Misses 136416 30852 -105564
+ Partials 9460 2479 -6981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What does this PR do?
Add endpoints to diagnose command
Motivation
https://datadoghq.atlassian.net/browse/ASCII-707
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
All old endpoints in
datadog-agent diagnose
should behave exactly the same as beforeAll new endpoints in
datadog-agent diagnose
should succeed