Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create_rc): Add git config to be able to push tag #27548

Closed
wants to merge 5 commits into from

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jul 12, 2024

What does this PR do?

Add missing git config

Motivation

Fix issue

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouetz chouetz requested review from a team as code owners July 12, 2024 14:16
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 12, 2024
@chouetz chouetz force-pushed the nschweitzer/add_git_config branch from 2b84ed9 to 3189a33 Compare July 12, 2024 14:33
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 12, 2024

[Fast Unit Tests Report]

On pipeline 39050228 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@chouetz chouetz force-pushed the nschweitzer/add_git_config branch 2 times, most recently from 8813121 to 1798988 Compare July 12, 2024 15:34
@chouetz chouetz force-pushed the nschweitzer/add_git_config branch from 1798988 to 797fee0 Compare July 12, 2024 15:40
@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2024

Regression Detector

Regression Detector Results

Run ID: 047f1ded-24b1-4bc4-96f9-4e7ed3e4bf11 Metrics dashboard Target profiles

Baseline: 21795c4
Comparison: 797fee0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_1000_100byte_tags % cpu utilization +3.40 [-1.33, +8.12] Logs
tcp_syslog_to_blackhole ingress throughput +1.41 [-11.66, +14.48] Logs
basic_py_check % cpu utilization +0.97 [-1.63, +3.57] Logs
file_tree memory utilization +0.63 [+0.52, +0.73] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.32 [-0.57, +1.20] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
otel_to_otel_logs ingress throughput -0.05 [-0.86, +0.76] Logs
idle memory utilization -0.27 [-0.30, -0.23] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouetz chouetz closed this Sep 19, 2024
@chouetz chouetz deleted the nschweitzer/add_git_config branch September 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant