-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clusteragent/autoscaling] Add telemetry metrics for autoscaling controller #28115
Conversation
Regression DetectorRegression Detector ResultsRun ID: 38014940-d618-4655-a287-e9a5434b8577 Metrics dashboard Target profiles Baseline: 6108bcf Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +0.82 | [+0.00, +1.63] | Logs |
➖ | idle | memory utilization | +0.31 | [+0.28, +0.35] | Logs |
➖ | file_tree | memory utilization | +0.29 | [+0.23, +0.35] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
➖ | basic_py_check | % cpu utilization | -0.08 | [-2.86, +2.70] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.43 | [-1.31, +0.46] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.67 | [-5.46, +4.12] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.69 | [-14.22, +10.84] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=41250820 --os-family=ubuntu Note: This applies to commit c6f367c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for files owned by ASC
eb5f081
to
523619c
Compare
523619c
to
c6f367c
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add the following telemetry metrics around the autoscaling controller:
autoscaling.queue_*
autoscaling.status_conditions
workload_autoscaling.horizontal_scaling
workload_autoscaling.vertical_scaling
Motivation
Improve monitoring and debugging.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Deploy Cluster Agent with autoscaling controller activated,
autoscaling.*
metrics should be available on Prom endpoint (localhost:5000/metrics
).With Agent >= 7.57, metrics should also be scrape by DCA integration