Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/DataDog/sketches-go from 1.4.2 to 1.4.6 in /pkg/trace #29872

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2024

Bumps github.com/DataDog/sketches-go from 1.4.2 to 1.4.6.

Release notes

Sourced from github.com/DataDog/sketches-go's releases.

v1.4.6

What's Changed

New Contributors

Full Changelog: DataDog/sketches-go@v1.4.5...v1.4.6

v1.4.5

What's Changed

New Contributors

Full Changelog: DataDog/sketches-go@v1.4.4...v1.4.5

v1.4.4

  • #76: Use sort.Ints in the buffered paginated store for better performance

v1.4.3

  • #74: Fix nullable pointer dereference in FromProto.
  • #75: Remove deprecated protobuf dependency.
Commits
  • f301b7a Merge pull request #80 from gduranceau/guillaume.duranceau/no-fma
  • d0e372d Avoid inconsistent quantile computation between architectures
  • 35c0e1c Merge pull request #78 from darccio/dario.castane/remove-deprecated-protobuf-...
  • cd7dee3 go.mod: update google.golang.org/protobuf to v1.32.0 & set go directive to 1.18
  • f1dba4d Merge pull request #76 from jeschkies/karsten/use-better-sort
  • 84acf1f Use sort.Ints for better performance.
  • d02c7fa Merge pull request #75 from DataDog/cmasson/remove_deprecated_protobuf
  • 944592c Remove deprecated protobuf dependency
  • 83610c4 Merge pull request #74 from paullegranddc/paullgdc/fix_from_proto_nil_deref
  • 96d776b Add test cases for nil pb structs fields
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/DataDog/sketches-go](https://github.com/DataDog/sketches-go) from 1.4.2 to 1.4.6.
- [Release notes](https://github.com/DataDog/sketches-go/releases)
- [Commits](DataDog/sketches-go@v1.4.2...v1.4.6)

---
updated-dependencies:
- dependency-name: github.com/DataDog/sketches-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 7, 2024 15:24
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/agent-apm trace-agent labels Oct 7, 2024
@github-actions github-actions bot requested a review from a team as a code owner October 7, 2024 15:30
@github-actions github-actions bot requested a review from jackgopack4 October 7, 2024 15:30
Copy link

Regression Detector

Regression Detector Results

Run ID: 9387b29a-541d-4995-9703-05a7ef593d85 Metrics dashboard Target profiles

Baseline: 45c13a2
Comparison: 325d73b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.65 [+1.92, +3.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.04 [+0.98, +1.09] 1 Logs
otel_to_otel_logs ingress throughput +0.31 [-0.50, +1.11] 1 Logs
file_tree memory utilization +0.10 [-0.03, +0.23] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.11, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
idle_all_features memory utilization -0.17 [-0.29, -0.06] 1 Logs
idle memory utilization -0.20 [-0.25, -0.15] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.70 [-3.24, +1.84] 1 Logs
basic_py_check % cpu utilization -2.13 [-4.80, +0.53] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackgopack4 jackgopack4 added team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Oct 10, 2024
@ajgajg1134
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 4f3aafc into main Nov 4, 2024
218 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/go_modules/pkg/trace/github.com/DataDog/sketches-go-1.4.6 branch November 4, 2024 21:49
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency qa/no-code-change No code change in Agent code requiring validation team/agent-apm trace-agent team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants