-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/DataDog/sketches-go from 1.4.2 to 1.4.6 in /pkg/trace #29872
Bump github.com/DataDog/sketches-go from 1.4.2 to 1.4.6 in /pkg/trace #29872
Conversation
Bumps [github.com/DataDog/sketches-go](https://github.com/DataDog/sketches-go) from 1.4.2 to 1.4.6. - [Release notes](https://github.com/DataDog/sketches-go/releases) - [Commits](DataDog/sketches-go@v1.4.2...v1.4.6) --- updated-dependencies: - dependency-name: github.com/DataDog/sketches-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Regression DetectorRegression Detector ResultsRun ID: 9387b29a-541d-4995-9703-05a7ef593d85 Metrics dashboard Target profiles Baseline: 45c13a2 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.65 | [+1.92, +3.38] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.04 | [+0.98, +1.09] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.31 | [-0.50, +1.11] | 1 | Logs |
➖ | file_tree | memory utilization | +0.10 | [-0.03, +0.23] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.11, +0.11] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.17 | [-0.29, -0.06] | 1 | Logs |
➖ | idle | memory utilization | -0.20 | [-0.25, -0.15] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.70 | [-3.24, +1.84] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -2.13 | [-4.80, +0.53] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Bumps github.com/DataDog/sketches-go from 1.4.2 to 1.4.6.
Release notes
Sourced from github.com/DataDog/sketches-go's releases.
Commits
f301b7a
Merge pull request #80 from gduranceau/guillaume.duranceau/no-fmad0e372d
Avoid inconsistent quantile computation between architectures35c0e1c
Merge pull request #78 from darccio/dario.castane/remove-deprecated-protobuf-...cd7dee3
go.mod: update google.golang.org/protobuf to v1.32.0 & set go directive to 1.18f1dba4d
Merge pull request #76 from jeschkies/karsten/use-better-sort84acf1f
Use sort.Ints for better performance.d02c7fa
Merge pull request #75 from DataDog/cmasson/remove_deprecated_protobuf944592c
Remove deprecated protobuf dependency83610c4
Merge pull request #74 from paullegranddc/paullgdc/fix_from_proto_nil_deref96d776b
Add test cases for nil pb structs fieldsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)