Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2125] Add E2E test for no dd exporter case #30069

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Oct 11, 2024

What does this PR do?

Add an E2E test case for OTel agent with no datadog exporter config.

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Oct 11, 2024
@songy23 songy23 added this to the 7.60.0 milestone Oct 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49672657 --os-family=ubuntu

Note: This applies to commit d80f5c6

Copy link

cit-pr-commenter bot commented Oct 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4dea894d-d6a6-48e5-a4ed-bb5ad57d54e9

Baseline: efa45af
Comparison: d80f5c6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +2.63 [+2.50, +2.76] 1 Logs
quality_gate_idle_all_features memory utilization +1.67 [+1.57, +1.77] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.15 [-0.63, +0.93] 1 Logs
quality_gate_idle memory utilization +0.10 [+0.03, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.74, +0.79] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.84, +0.89] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.70, +0.68] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.64, +0.60] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.53, +0.40] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.47 [-1.20, +0.26] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.02 [-1.09, -0.95] 1 Logs
otel_to_otel_logs ingress throughput -1.03 [-1.71, -0.34] 1 Logs
pycheck_lots_of_tags % cpu utilization -3.34 [-6.73, +0.05] 1 Logs
basic_py_check % cpu utilization -4.72 [-8.41, -1.03] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_1000ms_latency lost_bytes 0/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@songy23 songy23 force-pushed the yang.song/OTEL-2125 branch from 5656322 to 2964cd5 Compare October 15, 2024 17:42
@songy23 songy23 force-pushed the yang.song/OTEL-2125 branch from 327c7dd to eea7517 Compare October 30, 2024 19:00
@github-actions github-actions bot added medium review PR review might take time long review PR is complex, plan time to review it and removed medium review PR review might take time labels Oct 30, 2024
@songy23 songy23 force-pushed the yang.song/OTEL-2125 branch from 6be9e89 to bc53842 Compare November 1, 2024 19:08
@github-actions github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Nov 1, 2024
@songy23 songy23 force-pushed the yang.song/OTEL-2125 branch from bc53842 to a7ceae0 Compare November 5, 2024 18:58
@songy23 songy23 force-pushed the yang.song/OTEL-2125 branch from ccd9d98 to 6910c0e Compare November 21, 2024 14:29
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 21, 2024

[Fast Unit Tests Report]

On pipeline 49672657 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant