Add infra agent config option #30137
Conversation
Merge core payload flags into a single infra_agent flag. This is going to be used for Error Tracking Standalone where Infrastructure Monitoring is not needed, and makes it easier for users to understand and disable it.
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50073041 --os-family=ubuntuNote: This applies to commit 481e0ea |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c5298c3 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.65 | [-0.14, +1.43] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.39 | [-0.38, +1.16] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.05 | [-0.41, +0.52] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.03 | [-0.70, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.70, +0.73] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.65] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.09, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.84, +0.86] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.06, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.25 | [-0.39, -0.10] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.33 | [-4.14, +3.48] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.48 | [-1.18, +0.21] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.73 | [-4.17, +2.71] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.78 | [-0.90, -0.67] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.97 | [-1.03, -0.91] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
releasenotes/notes/add-infra-agent-config-option-a066d0571014d2bc.yaml
Outdated
Show resolved
Hide resolved
Also remove it from the config template and remove the release note.
Name seems more meaningful and can be reused more easily in the future.
Co-authored-by: Carlos <carlos.roman@datadoghq.com>
github-actions
bot
added
long review
Co-authored-by: Pierre Gimalac <pierre.gimalac@datadoghq.com>
Guillaume-Barrier
changed the base branch from
main
to
guillaume.barrier/add-error-tracking-standalone-config-option
If the core agent is disabled but the host is set as Error Tracking Standalone, we need to enable the trace agent.
Users don't have to explicitely enable APM to get ETS, yet they need core_agent if they want APM without ETS
|
/merge |
Devflow running:
|
| config.Set("enable_payloads.series", false, pkgconfigmodel.SourceAgentRuntime) | ||
| config.Set("enable_payloads.service_checks", false, pkgconfigmodel.SourceAgentRuntime) | ||
| config.Set("enable_payloads.sketches", false, pkgconfigmodel.SourceAgentRuntime) | ||
| } |
There was a problem hiding this comment.
what happens if the customer has defined these settings manually?
There was a problem hiding this comment.
core_agent.enabled takes precedence if specified. As mentioned in this doc core_agent.enabled is just grouping all these existing flags into one for an easier setup.
| @@ -31,3 +31,21 @@ func SetLogLevel(level string, config pkgconfigmodel.Writer, source pkgconfigmod | |||
| config.Set("log_level", seelogLogLevel, source) | |||
| return nil | |||
| } | |||
|
|
|||
| // IsCoreAgentEnabled checks if the Agent is able to send the payloads it and other Agents need to function with | |||
| func IsCoreAgentEnabled(cfg pkgconfigmodel.Reader) bool { | |||
There was a problem hiding this comment.
nit: IMO this function name is bit deceptive, I would have expected only core_agent.enabled to be relevant for it's resolution
There was a problem hiding this comment.
I agree. However, as mentioned in this comment core_agent.enabled is an "alias" for other existing flags so we have to check for both in this section to make sure they're compatible in case all of them are set at the same time.
I don't have a better idea, but if you have I'm more than happy to change it :)
There was a problem hiding this comment.
I think the duplicated boolean logic needs more/better documentation on why it's that way, or just rely on the existing apm_config.enabled.
I also believe the core_agent.enabled and the enable_payloads.* logic needs more comments or linked documentation on what it does. It's hard to reason about this code without reading the doc linked in the review comments.
Could you also add QA label or QA instructions? 🙏
|
/merge |
Devflow running:
|
GianlucaBortoli
added
the
qa/done
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
dd-mergequeue
bot
deleted the
guillaume.barrier/add-infra-agent-config-option
branch
What does this PR do?
Merge core payload flags into a single
core_agentflag available for users to disable.Motivation
This is going to be used for Error Tracking Standalone where Infrastructure Monitoring is not needed, and makes it easier for users to understand and disable it. Those 4 flags are also disabled if users only want Log Collection through the agent (see public doc); process is now easier and less error prone.
https://datadoghq.atlassian.net/browse/ERRORT-4748