Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] add kernel bpf filter for raw packet #30288

Merged
merged 35 commits into from
Nov 25, 2024
Merged

Conversation

safchain
Copy link
Contributor

@safchain safchain commented Oct 18, 2024

What does this PR do?

This PR introduces bpf filter to eBPF filters. It converts bpf filters in to a chain of tail calls that is called from the first raw packet classifier and that eventually call the prog that send the raw packet event.

Motivation

Apply a first filtering pass at the eBPF/kernel level to limit the performance impact.

Describe how to test/QA your changes

There are already functional tests for the raw packets feature, they should still pass.

Possible Drawbacks / Trade-offs

Additional Notes

@safchain safchain added this to the Triage milestone Oct 18, 2024
@safchain safchain requested a review from a team as a code owner October 18, 2024 16:51
@safchain safchain closed this Oct 18, 2024
@safchain safchain reopened this Oct 18, 2024
@safchain safchain marked this pull request as draft October 18, 2024 16:53
Copy link

cit-pr-commenter bot commented Oct 18, 2024

Go Package Import Differences

Baseline: bd961d3
Comparison: 41b7614

binaryosarchchange
system-probelinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/pkg/security/ebpf/probes/rawpacket
+github.com/cloudflare/cbpfc
system-probelinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/pkg/security/ebpf/probes/rawpacket
+github.com/cloudflare/cbpfc

@safchain safchain force-pushed the safchain/bpf-to-ebpf branch from 0ec0a73 to f9d6574 Compare November 12, 2024 09:42
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Nov 12, 2024
@safchain safchain force-pushed the safchain/bpf-to-ebpf branch from f9d6574 to 1e50ec0 Compare November 15, 2024 16:42
Copy link

cit-pr-commenter bot commented Nov 15, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0ea8150b-7a93-4756-81f3-cdcef72fcb1f

Baseline: bd961d3
Comparison: 41b7614
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.60 [-0.93, +6.13] 1 Logs
otel_to_otel_logs ingress throughput +0.80 [+0.15, +1.45] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.45 [-0.28, +1.18] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.28 [-0.50, +1.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.11 [+0.04, +0.18] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.72, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.75, +0.82] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.78, +0.82] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.18 [-0.64, +0.28] 1 Logs
quality_gate_idle memory utilization -0.51 [-0.57, -0.46] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization -0.57 [-4.36, +3.22] 1 Logs
file_tree memory utilization -1.32 [-1.44, -1.20] 1 Logs
quality_gate_idle_all_features memory utilization -2.54 [-2.68, -2.39] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@safchain safchain force-pushed the safchain/bpf-to-ebpf branch 2 times, most recently from d8f265e to ff36b67 Compare November 18, 2024 11:21
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49841243 --os-family=ubuntu

Note: This applies to commit 41b7614

@safchain safchain force-pushed the safchain/bpf-to-ebpf branch from 2e6a6a6 to b02dadd Compare November 19, 2024 09:05
@safchain safchain modified the milestones: Triage, 7.61.0 Nov 19, 2024
@safchain safchain added the qa/done QA done before merge and regressions are covered by tests label Nov 19, 2024
@safchain safchain marked this pull request as ready for review November 19, 2024 09:10
@safchain safchain changed the title [CWS][WIP] add kernel bpf filter [CWS] add kernel bpf filter for raw packet Nov 19, 2024
@safchain safchain force-pushed the safchain/bpf-to-ebpf branch 7 times, most recently from 9846cfc to 0359eab Compare November 21, 2024 16:52
@safchain safchain force-pushed the safchain/bpf-to-ebpf branch from ad94a25 to 0372414 Compare November 22, 2024 16:39
@safchain safchain force-pushed the safchain/bpf-to-ebpf branch from 0372414 to fd0c74f Compare November 22, 2024 17:42

return p.Manager.UpdateTailCallRoutes(
manager.TailCallRoute{
// setup tail calls
Copy link
Contributor

@YoannGh YoannGh Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a check here against RawPacketFilterMaxTailCall to make sure we don't end up overwriting the classifier_raw_packet_sender program entry?

@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 25, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-25 12:54:55 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit cfaf5ee into main Nov 25, 2024
224 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/bpf-to-ebpf branch November 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants