-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init commit debug utils #30474
init commit debug utils #30474
Conversation
Regression Detector |
[Fast Unit Tests Report] On pipeline 47920908 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
# TODO: hacky way to get the version from the archive name, is there a better way? | ||
# the setup-agent-version job stores the version in a private bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be able to compute using that function:
Lines 777 to 789 in b738388
@task | |
def version( | |
ctx, | |
url_safe=False, | |
omnibus_format=False, | |
git_sha_length=7, | |
major_version='7', | |
cache_version=False, | |
pipeline_id=None, | |
include_git=True, | |
include_pre=True, | |
release=False, | |
): |
But not sure what parameters you would need to pass.
If that works like that I guess this is fine for a first PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this leads to query_version
which runs git commands. If those commands support being given a refspec i might be able to give it commit hash from the pipeline, but it would only work if you have the refspec locally, too. it might be nice to have a clone of the repo at that commit, though, so the source matches.
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add invoke tasks (and helpers) to
implemented fetch/extract for windows, suse, and debian debug packages.
rpm2cpio
anddpkg-deb
persists/caches downloaded files into
~/.agent-crash-analyzer/
Motivation
automation
based on info from https://datadoghq.atlassian.net/wiki/spaces/agent/pages/3777987099/Loading+an+agent+core+dump
Describe how to test/QA your changes
run unit tests
run some of the invoke tasks and see if you get symbols/dumps
Possible Drawbacks / Trade-offs
there doesn't seem to be a way to list artifacts or download a specific artifact, so all the artifacts get downloaded.
This is nice for e2e test artifacts because you get the dump and the agent logs
but is not nice for package build artifacts when we only care about the debug symbol archive and the other artifacts are large. maybe we could upload the debug packages to the mstesting bucket, too.
Additional Notes
Not sure where to get debug symbols for release candidate builds for Linux platforms