Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] refactored gpu probe to decouple init and start phases #30615

Merged
merged 15 commits into from
Nov 6, 2024
Merged

[EBPF] refactored gpu probe to decouple init and start phases #30615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e58cdbd
refactored gpu probe to have init (ctor) and start phases.
val06 Oct 30, 2024
7091a09
replaced hard-coded string with module name var
val06 Oct 30, 2024
7728ec0
- removed unnecessary parameter from probe Start method
val06 Oct 30, 2024
5e55cd3
revert probe pkg introduction, to avoid unnecessary public types and …
val06 Oct 30, 2024
827a136
fixed typo
val06 Oct 30, 2024
8070311
fixed imports
val06 Oct 30, 2024
ce8e0f7
changed global eventHandler to interface and moved assignment to the …
val06 Oct 30, 2024
96e0809
rebased main
val06 Nov 5, 2024
c10a701
changed start to be an internal method of the probe called during the…
val06 Nov 5, 2024
1f40d96
removed probes declaration when creating the manager
val06 Nov 6, 2024
10f9aa6
rebase fixes
val06 Nov 6, 2024
ae803c2
Update pkg/gpu/probe.go
val06 Nov 6, 2024
acbfe11
moved global eventHandler var to be part of the Probe struct (CR note)
val06 Nov 6, 2024
7aec75b
Merge remote-tracking branch 'origin/valeri.pliskin/refactor-gpu-prob…
val06 Nov 6, 2024
750171b
moved ringbuffer eventHandler stop to the probe
val06 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/system-probe/modules/gpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ var GPUMonitoring = module.Factory{
return nil, fmt.Errorf("unable to initialize NVML library: %v", ret)
}

t, err := gpu.NewProbe(c, probeDeps)
p, err := gpu.NewProbe(c, probeDeps)
if err != nil {
return nil, fmt.Errorf("unable to start GPU monitoring: %w", err)
return nil, fmt.Errorf("unable to start %s: %w", config.GPUMonitoringModule, err)
}

return &GPUMonitoringModule{
Probe: t,
Probe: p,
lastCheck: atomic.NewInt64(0),
}, nil
},
Expand Down
1 change: 0 additions & 1 deletion pkg/gpu/consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func (c *cudaEventConsumer) Stop() {
if c == nil {
return
}
c.eventHandler.Stop()
c.once.Do(func() {
close(c.closed)
})
Expand Down
Loading
Loading