Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow absolute paths to verifier calculator #30677

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

brycekahle
Copy link
Member

What does this PR do?

Allows the verifier complexity calculator to operate on absolute paths

Motivation

Runtime generated programs do not sit in the normal bpf directory, so the -filter-file argument needs to allow absolute paths.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@brycekahle brycekahle added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Oct 31, 2024
@brycekahle brycekahle added this to the 7.61.0 milestone Oct 31, 2024
@brycekahle brycekahle requested a review from a team as a code owner October 31, 2024 21:13
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Oct 31, 2024
@grantseltzer
Copy link
Member

Do you want to also add the debug line for printing the object file path?

@brycekahle
Copy link
Member Author

Do you want to also add the debug line for printing the object file path?

Yes, added.

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48018256 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48018256 --os-family=ubuntu

Note: This applies to commit 5c0392a

Copy link

Regression Detector

Regression Detector Results

Run ID: 04482006-1702-4f6e-af63-3e245f4cccb2 Metrics dashboard Target profiles

Baseline: 711d80f
Comparison: 5c0392a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.17 [+0.45, +1.89] 1 Logs
idle_all_features memory utilization +0.52 [+0.42, +0.63] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization +0.50 [-2.13, +3.14] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.15 [-0.10, +0.39] 1 Logs
idle memory utilization +0.07 [+0.02, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.06 [-0.44, +0.55] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.08, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.23, +0.21] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.19, +0.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.37, +0.31] 1 Logs
otel_to_otel_logs ingress throughput -0.04 [-0.85, +0.77] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.20 [-0.26, -0.15] 1 Logs
quality_gate_idle memory utilization -0.22 [-0.27, -0.17] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.23 [-0.33, -0.12] 1 Logs bounds checks dashboard
file_tree memory utilization -0.42 [-0.55, -0.30] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.90 [-4.34, +0.54] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@brycekahle
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit bf7feff into main Nov 4, 2024
295 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bryce.kahle/fix-verifier-abs-path branch November 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants