Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): Add the gitlab linter to agent6 #30713

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Nov 4, 2024

What does this PR do?

Add the gitlab configuration linter to Agent6 branch

Motivation

Test locally the configuration before submitting huge modifications on the branch (cf #30261)

Describe how to test/QA your changes

The gitlab lint test passes

Possible Drawbacks / Trade-offs

Additional Notes

* feat(ci): Add the linter gitlab

* Add the linter to pre-commit

* Add the linter to the CI

* codereview: update logging, comment and file format
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 4, 2024
@chouetz chouetz requested review from a team as code owners November 4, 2024 14:44
@chouetz chouetz force-pushed the nschweitzer/add_linter branch from 8484d1b to 1f8ad42 Compare November 4, 2024 15:25
Copy link
Contributor

@CelianR CelianR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but might not be necessary if we separate tasks from the agent 6 / 7 repository

@chouetz chouetz merged commit c0d64bb into 6.53.x Nov 5, 2024
171 of 207 checks passed
@chouetz chouetz deleted the nschweitzer/add_linter branch November 5, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants