Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMP] Update Quality Gate experiment #30720

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

GeorgeHahn
Copy link
Contributor

@GeorgeHahn GeorgeHahn commented Nov 4, 2024

What does this PR do?

Follow-up from #30687. Update the idle quality gate and add notes to the idle experiments. We plan to switch quality gate reports to the quality_gate prefixed experiments in the next week or two.

@GeorgeHahn GeorgeHahn changed the title Use qg prefix [SMP] Use Qua Nov 4, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GeorgeHahn and the rest of your teammates on Graphite Graphite

@GeorgeHahn GeorgeHahn changed the title [SMP] Use Qua [SMP] Update Quality Gate experiment Nov 4, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 4, 2024
@GeorgeHahn GeorgeHahn marked this pull request as ready for review November 4, 2024 18:45
@GeorgeHahn GeorgeHahn requested a review from a team as a code owner November 4, 2024 18:45
@GeorgeHahn
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48184516 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 88a940f into main Nov 4, 2024
220 of 223 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hahn/use_qg_prefix branch November 4, 2024 19:42
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 4, 2024
@FlorentClarret FlorentClarret added the qa/no-code-change No code change in Agent code requiring validation label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants