Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smp]: idle_all_features gate: 785 MiB -> 770 MiB #30745

Merged

Conversation

goxberry
Copy link
Contributor

@goxberry goxberry commented Nov 4, 2024

What does this PR do?

This commit tightens the upper bound on Agent's idle_all_features memory consumption, stating that the overhead of Agent with all features enabled is no more than 770 MiB by default, instead of the previous 785 MiB.

Motivation

Reduce Agent resource usage.

Describe how to test/QA your changes

Quality gates runs will test the changes.

Possible Drawbacks / Trade-offs

Less headroom for features, lower operating costs for customers (we hope).

Additional Notes

n/a

This commit tightens the upper bound on Agent's `idle_all_features`
memory consumption, stating that the overhead of Agent with all
features enabled is no more than 770 MiB by default, instead of the
previous 785 MiB.

Signed-off-by: Geoffrey M. Oxberry <geoffrey.oxberry@datadoghq.com>
@goxberry goxberry added changelog/no-changelog team/single-machine-performance Single Machine Performance qa/no-code-change No code change in Agent code requiring validation labels Nov 4, 2024
@goxberry goxberry requested a review from a team as a code owner November 4, 2024 21:23
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 4, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48203477 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

@goxberry
Copy link
Contributor Author

goxberry commented Nov 5, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 21m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit a768f24 into main Nov 5, 2024
231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the goxberry/smp-idle_all_features-quality-gate-limit branch November 5, 2024 02:54
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants