Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][gitlab] release OTel to public facing repos on relevant tags (#30641) #30748

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Nov 4, 2024

What does this PR do?

This PR backports #30641 to 7.60.x.

Motivation

Enable the OTel Beta release workflow on the 7.60.x branch (already in main).

Describe how to test/QA your changes

Gitlab change, no QA necessary. Issues, hopefully none, will be evident and validated with the gitlab pipeline behavior.

Possible Drawbacks / Trade-offs

Additional Notes

@truthbk truthbk requested review from a team as code owners November 4, 2024 23:18
@github-actions github-actions bot added team/agent-delivery short review PR is simple enough to be reviewed quickly labels Nov 4, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48214343 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Run ID: cab5ad6d-c900-47a8-a7b0-51cabc16a7c5 Metrics dashboard Target profiles

Baseline: 8d087c9
Comparison: cf3f05c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +2.29 [-0.46, +5.05] 1 Logs
pycheck_lots_of_tags % cpu utilization +1.74 [-0.81, +4.30] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.90 [+0.84, +0.96] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.41 [-0.32, +1.14] 1 Logs
file_tree memory utilization +0.13 [-0.00, +0.25] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.18, +0.32] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.08, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.35] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.20, +0.18] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.24, +0.21] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.11, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.55, +0.44] 1 Logs
idle_all_features memory utilization -0.06 [-0.16, +0.04] 1 Logs bounds checks dashboard
idle memory utilization -0.08 [-0.13, -0.03] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.26 [-0.31, -0.21] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -1.48 [-2.29, -0.68] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@truthbk
Copy link
Member Author

truthbk commented Nov 5, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.60.x is 19m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 282f0f1 into 7.60.x Nov 5, 2024
214 of 215 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jaime/gitlab_760backport branch November 5, 2024 12:41
@github-actions github-actions bot added this to the 7.60.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants