fix(installer): Properly support DD_AGENT_MINOR_VERSION when it's not in the minor.patch format #30754
+69
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the minor.patch format
github-actions
bot
added
short review
BaptisteFoy
added
changelog/no-changelog
qa/done
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48230721 --os-family=ubuntuNote: This applies to commit 140d378 |
Regression Detector |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
coignetp
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports setting
DD_AGENT_MINOR_VERSION=58Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes