-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fleet): Ignore public.ecr.aws overrides #30805
Conversation
796e311
to
7003a54
Compare
a2c2c63
to
707c5dd
Compare
707c5dd
to
2fb61d7
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48346288 --os-family=ubuntu Note: This applies to commit 707c5dd |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: eb4fbb5 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.05 | [+0.96, +1.13] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.11, +0.38] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.13 | [+0.08, +0.19] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.45, +0.52] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.32, +0.34] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.22, +0.23] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.11, +0.08] | 1 | Logs |
➖ | file_tree | memory utilization | -0.05 | [-0.18, +0.07] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.07 | [-0.25, +0.11] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.17 | [-0.28, -0.07] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.32 | [-1.05, +0.41] | 1 | Logs |
➖ | idle | memory utilization | -1.03 | [-1.08, -0.98] | 1 | Logs bounds checks dashboard |
➖ | idle_all_features | memory utilization | -1.28 | [-1.39, -1.18] | 1 | Logs bounds checks dashboard |
➖ | pycheck_lots_of_tags | % cpu utilization | -2.14 | [-5.73, +1.44] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -3.39 | [-7.10, +0.31] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | quality_gate_idle | memory_usage | 9/10 | bounds checks dashboard |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Motivation
Describe how to test/QA your changes
Install an installer with override registry set to public.ecr.aws/datadog; then go check telemetry traces -- you shouldn't be pulling from public.ecr.aws
Possible Drawbacks / Trade-offs
Additional Notes