Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fleet): Ignore public.ecr.aws overrides #30805

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Nov 6, 2024

What does this PR do?

Motivation

Describe how to test/QA your changes

Install an installer with override registry set to public.ecr.aws/datadog; then go check telemetry traces -- you shouldn't be pulling from public.ecr.aws

Possible Drawbacks / Trade-offs

Additional Notes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Nov 6, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 6, 2024
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/ignore-public-ecr branch 2 times, most recently from 796e311 to 7003a54 Compare November 6, 2024 13:33
@BaptisteFoy BaptisteFoy marked this pull request as ready for review November 6, 2024 13:35
@BaptisteFoy BaptisteFoy requested review from a team as code owners November 6, 2024 13:35
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/ignore-public-ecr branch from a2c2c63 to 707c5dd Compare November 6, 2024 13:56
@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/ignore-public-ecr branch from 707c5dd to 2fb61d7 Compare November 6, 2024 13:57
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 6, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48346288 --os-family=ubuntu

Note: This applies to commit 707c5dd

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5eca640f-6664-464e-b300-7dafa1f642c7

Baseline: eb4fbb5
Comparison: 2fb61d7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.05 [+0.96, +1.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.11, +0.38] 1 Logs
quality_gate_idle memory utilization +0.13 [+0.08, +0.19] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.45, +0.52] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.32, +0.34] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.22, +0.23] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.11, +0.08] 1 Logs
file_tree memory utilization -0.05 [-0.18, +0.07] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.07 [-0.25, +0.11] 1 Logs
quality_gate_idle_all_features memory utilization -0.17 [-0.28, -0.07] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.32 [-1.05, +0.41] 1 Logs
idle memory utilization -1.03 [-1.08, -0.98] 1 Logs bounds checks dashboard
idle_all_features memory utilization -1.28 [-1.39, -1.18] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -2.14 [-5.73, +1.44] 1 Logs
basic_py_check % cpu utilization -3.39 [-7.10, +0.31] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 76e6655 into main Nov 6, 2024
223 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/ignore-public-ecr branch November 6, 2024 16:06
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants