Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][gitlab] contaiener_deploy: fix missing targets #30790 #30810

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Nov 6, 2024

What does this PR do?

Backports PR #30790 to 7.60.x where it is required to successfully deploy the RC and final images automatically for OTel beta builds.

Motivation

Introduces a fix on top of PR #30641 which actually had a problem due to undefined targets for a couple of container_deploy jobs.

Describe how to test/QA your changes

OTel beta workflow will validate the changes. Already tested on a test branch.

Possible Drawbacks / Trade-offs

Additional Notes

@truthbk truthbk added this to the 7.60.0 milestone Nov 6, 2024
@truthbk truthbk requested review from a team as code owners November 6, 2024 14:31
@github-actions github-actions bot added team/agent-delivery short review PR is simple enough to be reviewed quickly labels Nov 6, 2024
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b3022a4e-1dc5-4614-a94f-247f09ce677b

Baseline: 0bf64ee
Comparison: 0f97d17
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +0.94 [-3.09, +4.97] 1 Logs
quality_gate_idle_all_features memory utilization +0.77 [+0.65, +0.89] 1 Logs bounds checks dashboard
idle memory utilization +0.50 [+0.45, +0.55] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.42 [+0.38, +0.46] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.11 [-0.64, +0.85] 1 Logs
quality_gate_idle memory utilization +0.09 [+0.03, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.31, +0.37] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.16, +0.21] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.20, +0.24] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.57, +0.40] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.34, +0.16] 1 Logs
idle_all_features memory utilization -0.30 [-0.40, -0.20] 1 Logs bounds checks dashboard
file_tree memory utilization -0.48 [-0.61, -0.35] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.68 [-4.19, +2.83] 1 Logs
otel_to_otel_logs ingress throughput -1.33 [-2.12, -0.53] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@truthbk
Copy link
Member Author

truthbk commented Nov 6, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.60.x is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 1ef4824 into 7.60.x Nov 6, 2024
219 of 222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jaime/backport-760x-30790 branch November 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants