Add Back Tags to Spans Sent from Serverless-Init

[duncanpharvey]

What does this PR do?

Add back tags to spans sent from Serverless-Init.

Motivation

Regression introduced in #30743

Describe how to test/QA your changes

Build serverless-init test image from https://github.com/DataDog/datadog-lambda-extension/tree/main/scripts.

VERSION=1.0.0 ./build_serverless_init.sh
cp -r .layers/. ./scripts/bin/
docker build --build-arg="TARGET_ARCH=amd64" --platform linux/amd64 -f Dockerfile.serverless-init.build -t duncanacrtesting.azurecr.io/serverless-init-testing:1.0.0 .
docker push duncanacrtesting.azurecr.io/serverless-init-testing:1.0.0

Deploy to Azure Container Apps

az containerapp up \
  --name node-container-profiling \
  --resource-group duncan-harvey-rg \
  --ingress external \
  --target-port 8080 \
  --env-vars "DD_API_KEY=<api key>" \
             "DD_SITE=datadoghq.com" \
             "DD_TRACE_ENABLED=true" \
             "DD_LOGS_ENABLED=true" \
             "DD_PROFILING_ENABLED=true" \
             "DD_AZURE_SUBSCRIPTION_ID=<subscription_id>" \
             "DD_AZURE_RESOURCE_GROUP=<resource group>" \
             "DD_SERVICE=node-container-profiling" \
             "DD_ENV=dev" \
             "DD_VERSION=1.0.0" \
             "DD_LOG_LEVEL=debug" \
  --image duncanacrtesting.azurecr.io/azure-container-app-hello-world-node:1.0.0

Application Code

var express = require('express');
var app = express();

app.get('/', async function (req, res) {
  console.log('node testing');
  res.send('Hello Datadog!');
});

app.listen(8080, function () {
  console.log('Example app listening on port 8080!');
});

Dockerfile

FROM node:22
WORKDIR /app
COPY package*.json index.js ./
RUN npm install
EXPOSE 8080

COPY --from=duncanacrtesting.azurecr.io/serverless-init-testing:1.0.0 /datadog-init /app/datadog-init

RUN npm install --prefix /dd_tracer/node dd-trace --save
ENV NODE_PATH="/dd_tracer/node/node_modules"
ENV NODE_OPTIONS="--require dd-trace/init"
ENTRYPOINT ["/app/datadog-init"]

CMD ["node", "index.js"]

Possible Drawbacks / Trade-offs

Additional Notes

A fix that addressed a race condition when adding profile tags removed the addition of span tags.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48358036 --os-family=ubuntu

Note: This applies to commit 8fcf323

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0a87ea64-97cf-4243-a615-ca05adaf787c

Baseline: 8e0f134
Comparison: 8e0f134
Diff

Optimization Goals: ❌ Significant changes detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	basic_py_check	% cpu utilization	+5.24	[+1.32, +9.15]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	basic_py_check	% cpu utilization	+5.24	[+1.32, +9.15]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+1.18	[-2.53, +4.89]	1	Logs
➖	idle	memory utilization	+1.01	[+0.94, +1.07]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.60	[+0.55, +0.66]	1	Logs
➖	quality_gate_idle	memory utilization	+0.36	[+0.29, +0.42]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.20, +0.30]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.48, +0.51]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.32, +0.35]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.10, +0.10]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.22, +0.22]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.20, +0.16]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.41	[-1.14, +0.33]	1	Logs
➖	file_tree	memory utilization	-1.10	[-1.24, -0.96]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-2.08	[-2.21, -1.95]	1	Logs bounds checks dashboard
➖	idle_all_features	memory utilization	-2.22	[-2.36, -2.09]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	idle	memory_usage	6/10	bounds checks dashboard
❌	quality_gate_idle	memory_usage	6/10	bounds checks dashboard
❌	quality_gate_idle_all_features	memory_usage	9/10	bounds checks dashboard
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	idle_all_features	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[duncanpharvey]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!